test(github): use t.Run subtests in TestTranslateGitHubReviewState; doc: note nil body in DeleteReview

2026-05-13 02:04:06 -07:00
parent 9dd5e8dbac
commit cd8a1becb3
2 changed files with 14 additions and 10 deletions
@@ -348,21 +348,24 @@ func TestDismissReview_401(t *testing.T) {

 func TestTranslateGitHubReviewState(t *testing.T) {
 	tests := []struct {
+		name  string
 		input string
 		want  string
 	}{
-		{"APPROVED", "APPROVED"},
-		{"CHANGES_REQUESTED", "REQUEST_CHANGES"},
-		{"COMMENTED", "COMMENT"},
-		{"DISMISSED", "DISMISSED"},
-		{"UNKNOWN_STATE", "UNKNOWN_STATE"},
-		{"", ""},
+		{"approved passes through", "APPROVED", "APPROVED"},
+		{"changes_requested maps to REQUEST_CHANGES", "CHANGES_REQUESTED", "REQUEST_CHANGES"},
+		{"commented maps to COMMENT", "COMMENTED", "COMMENT"},
+		{"dismissed passes through", "DISMISSED", "DISMISSED"},
+		{"unknown state passes through", "UNKNOWN_STATE", "UNKNOWN_STATE"},
+		{"empty string passes through", "", ""},
 	}
 	for _, tt := range tests {
-		got := translateGitHubReviewState(tt.input)
-		if got != tt.want {
-			t.Errorf("translateGitHubReviewState(%q) = %q, want %q", tt.input, got, tt.want)
-		}
+		t.Run(tt.name, func(t *testing.T) {
+			got := translateGitHubReviewState(tt.input)
+			if got != tt.want {
+				t.Errorf("translateGitHubReviewState(%q) = %q, want %q", tt.input, got, tt.want)
+			}
+		})
 	}
 }