rodin/review-bot
2
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 6 Wiki Activity

nit(#150): fix misleading 'this is unreachable' in Lstat comment

Browse Source
This commit is contained in:
Rodin
2026-05-15 16:10:27 -07:00
parent 345f9a5aac
commit 6e11107c77
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cmd/review-bot/validatedocmap.go
+2 -2
View File
@@ -50,8 +50,8 @@ func validateDocmapPath(localPath, resolvedRoot string) (string, error) {
return "", fmt.Errorf("cannot resolve path (symlink): %w", err) return "", fmt.Errorf("cannot resolve path (symlink): %w", err)
} }
// Lstat the resolved path — EvalSymlinks guarantees resolvedPath is // Lstat the resolved path for size and existence checks — EvalSymlinks
// symlink-free, so ModeSymlink can never be set here; this is unreachable. // guarantees no symlink components remain, so ModeSymlink can never be set.
fi, err := os.Lstat(resolvedPath) fi, err := os.Lstat(resolvedPath)
if err != nil { if err != nil {
return "", fmt.Errorf("cannot stat file: %w", err) return "", fmt.Errorf("cannot stat file: %w", err)