From 6e11107c77a2cba7f7f331e87aa2ca8ed112249b Mon Sep 17 00:00:00 2001 From: Rodin Date: Fri, 15 May 2026 16:10:27 -0700 Subject: [PATCH] nit(#150): fix misleading 'this is unreachable' in Lstat comment --- cmd/review-bot/validatedocmap.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/review-bot/validatedocmap.go b/cmd/review-bot/validatedocmap.go index af0abc2..31086ac 100644 --- a/cmd/review-bot/validatedocmap.go +++ b/cmd/review-bot/validatedocmap.go @@ -50,8 +50,8 @@ func validateDocmapPath(localPath, resolvedRoot string) (string, error) { return "", fmt.Errorf("cannot resolve path (symlink): %w", err) } - // Lstat the resolved path — EvalSymlinks guarantees resolvedPath is - // symlink-free, so ModeSymlink can never be set here; this is unreachable. + // Lstat the resolved path for size and existence checks — EvalSymlinks + // guarantees no symlink components remain, so ModeSymlink can never be set. fi, err := os.Lstat(resolvedPath) if err != nil { return "", fmt.Errorf("cannot stat file: %w", err)