rodin/review-bot
2
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 6 Wiki Activity

refactor(test): remove misleading t.Setenv in GitHub integration test
PR Ready Gate / clear-labels (pull_request) Successful in 1s
Details
CI / test (pull_request) Successful in 17s
Details
CI / review (anthropic--claude-4.6-sonnet, sonnet, SONNET_REVIEW_TOKEN) (pull_request) Successful in 25s
Details
CI / review (gpt-5, gpt, GPT_REVIEW_TOKEN) (pull_request) Successful in 1m1s
Details
CI / review (gpt-5, security, ., rodin/security-patterns, SECURITY_REVIEW.md, SECURITY_REVIEW_TOKEN) (pull_request) Successful in 1m0s
Details

Browse Source 
The test constructs github.Client directly (matching the Gitea integration
test pattern), so setting VCS_TYPE does not affect the code under test.
Remove the setenv call to avoid implying routing is being exercised.
This commit is contained in:
claw
2026-05-14 15:33:47 -07:00
parent bd516cd044
commit 4d48917e36
1 changed files with 0 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cmd/review-bot/integration_test.go
-4
View File
@@ -194,10 +194,6 @@ func TestIntegration_GitHub_PostAndVerifyReview(t *testing.T) {
owner, repoName := parts[0], parts[1] owner, repoName := parts[0], parts[1]
ctx := context.Background() ctx := context.Background()
// Verify the GitHub adapter is selected via VCS routing.
t.Setenv("VCS_TYPE", "github")
ghClient := github.NewClient(githubToken, "https://api.github.com") ghClient := github.NewClient(githubToken, "https://api.github.com")
// Verify adapter selection: GetAuthenticatedUser must succeed. // Verify adapter selection: GetAuthenticatedUser must succeed.