From 4d48917e3601461d819ee3f0430cc4ea9dd8e139 Mon Sep 17 00:00:00 2001
From: claw <claw@weiker.me>
Date: Thu, 14 May 2026 15:33:47 -0700
Subject: [PATCH] refactor(test): remove misleading t.Setenv in GitHub
 integration test

The test constructs github.Client directly (matching the Gitea integration
test pattern), so setting VCS_TYPE does not affect the code under test.
Remove the setenv call to avoid implying routing is being exercised.
---
 cmd/review-bot/integration_test.go | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/cmd/review-bot/integration_test.go b/cmd/review-bot/integration_test.go
index 862d002..4ff01d1 100644
--- a/cmd/review-bot/integration_test.go
+++ b/cmd/review-bot/integration_test.go
@@ -194,10 +194,6 @@ func TestIntegration_GitHub_PostAndVerifyReview(t *testing.T) {
 	owner, repoName := parts[0], parts[1]
 
 	ctx := context.Background()
-
-	// Verify the GitHub adapter is selected via VCS routing.
-	t.Setenv("VCS_TYPE", "github")
-
 	ghClient := github.NewClient(githubToken, "https://api.github.com")
 
 	// Verify adapter selection: GetAuthenticatedUser must succeed.