Sonnet Review Bot sonnet-review-bot
  • Joined on 2026-04-24
sonnet-review-bot commented on pull request rodin/review-bot#37 2026-05-02 18:20:45 +00:00
feat: improve test coverage for cmd/review-bot

[MINOR] Integration tests use context.Background() without a timeout when posting and listing reviews; using context.WithTimeout would make tests more robust to slow or unresponsive endpoints.

sonnet-review-bot commented on pull request rodin/review-bot#37 2026-05-02 18:20:45 +00:00
feat: improve test coverage for cmd/review-bot

[NIT] Subtest name derives from the file path (t.Run(tc.path)) and one case is an empty string; using a descriptive, non-empty subtest name would improve readability and avoid odd test names.

sonnet-review-bot commented on pull request rodin/review-bot#37 2026-05-02 18:15:37 +00:00
feat: improve test coverage for cmd/review-bot

[MINOR] Tests in TestEvaluateCIStatus assert on specific substrings of human-readable messages (e.g., "all checks passed"). This can make tests brittle if message phrasing changes despite correct behavior. Consider asserting on structured outcomes where possible.

sonnet-review-bot commented on pull request rodin/review-bot#37 2026-05-02 18:15:37 +00:00
feat: improve test coverage for cmd/review-bot

[NIT] Consider adding the 'coverage' target to the .PHONY list to avoid any potential name collision with a file named 'coverage'.

sonnet-review-bot commented on pull request rodin/review-bot#33 2026-05-02 16:52:20 +00:00
fix: distinguish 404 in GetAllFilesInPath, make uploads idempotent

[MINOR] In GetAllFilesInPath, when GetFileContent fails, the returned error wraps the earlier ListContents error (err) instead of the actual fileErr. This loses the specific cause of the file fetch failure. Prefer wrapping fileErr for better diagnostics.

sonnet-review-bot commented on pull request rodin/review-bot#33 2026-05-02 16:52:20 +00:00
fix: distinguish 404 in GetAllFilesInPath, make uploads idempotent

[NIT] The inline Python filter compares asset names using a shell-expanded ${filename} inside single quotes. If a filename ever contained a single quote, this would break the command. While current artifact names are safe, consider more robust quoting or using a tool like jq.

sonnet-review-bot approved rodin/review-bot#31 2026-05-02 14:27:00 +00:00
fix: remove worst-wins escalation logic

Sonnet Review

sonnet-review-bot commented on pull request rodin/review-bot#31 2026-05-02 14:27:00 +00:00
fix: remove worst-wins escalation logic

[MINOR] hasSharedToken does not filter out stale reviews when detecting shared-token misuse. If a stale sibling review from a prior misconfiguration remains under the same user, this may trigger a false positive and permanently skip update-in-place logic even after the configuration is fixed. Consider ignoring r.Stale in the detection loop.

sonnet-review-bot commented on pull request rodin/review-bot#31 2026-05-02 14:23:26 +00:00
fix: remove worst-wins escalation logic

[MINOR] When shared-token mode is detected, the code skips all update-in-place logic but also skips checking reviewUnchanged. This can lead to duplicate identical reviews being posted under the same login and sentinel. Consider still performing a reviewUnchanged check and returning early to avoid re-posting in this misconfiguration scenario.

sonnet-review-bot approved rodin/review-bot#31 2026-05-02 14:23:26 +00:00
fix: remove worst-wins escalation logic

Sonnet Review

sonnet-review-bot approved rodin/review-bot#31 2026-05-02 14:22:44 +00:00
fix: remove worst-wins escalation logic

Security Review

sonnet-review-bot approved rodin/review-bot#31 2026-05-02 14:08:10 +00:00
fix: remove worst-wins escalation logic

Sonnet Review

sonnet-review-bot approved rodin/review-bot#31 2026-05-02 14:08:07 +00:00
fix: remove worst-wins escalation logic

Security Review

sonnet-review-bot suggested changes for rodin/review-bot#26 2026-05-02 05:48:44 +00:00
feat: inline review comments on specific lines

Security Review