security-review-bot
  • Joined on 2026-05-02
security-review-bot commented on pull request rodin/review-bot#113 2026-05-13 20:06:39 +00:00
feat(github): add safeguards against accidental AllowInsecureHTTP use (#96)

[MINOR] The error message includes user-influenced URL data via redactURL(reqURL) without explicit newline/carriage-return sanitization. If upstream code logs this error directly, it could allow limited log injection if a crafted URL with control characters is accepted by url.Parse. Consider sanitizing \n/\r in the formatted error or ensuring redactURL strips such characters.

security-review-bot commented on pull request rodin/review-bot#113 2026-05-13 18:46:53 +00:00
feat(github): add safeguards against accidental AllowInsecureHTTP use (#96)

[MINOR] AllowInsecureHTTPForTest bypasses the env gate and does not emit a warning; as an exported option it could be mistakenly used in production, silently allowing plaintext HTTP. Consider restricting its availability to tests (e.g., define in a _test.go file) or emitting a warning when enabled to preserve operator visibility.

security-review-bot commented on pull request rodin/review-bot#113 2026-05-13 18:26:17 +00:00
feat(github): add safeguards against accidental AllowInsecureHTTP use (#96)

[MINOR] redactURL only strips query parameters and can still leak credentials if present in the userinfo component (e.g., http://user:pass@host/path). Consider parsing with url.Parse and redacting u.User and fragment to avoid potential secret exposure in logs.

security-review-bot commented on pull request rodin/review-bot#113 2026-05-13 18:26:17 +00:00
feat(github): add safeguards against accidental AllowInsecureHTTP use (#96)

[MAJOR] The HTTP-scheme guard in doRequest uses a case-sensitive prefix check (strings.HasPrefix(reqURL, "http://"). URI schemes are case-insensitive (RFC 3986), so a URL like "HTTP://..." bypasses the guard and may send credentials over plaintext. Parse the URL and compare scheme case-insensitively (e.g., url.Parse + strings.EqualFold(u.Scheme, "http")).

security-review-bot commented on pull request rodin/review-bot#113 2026-05-13 17:50:22 +00:00
feat(github): add safeguards against accidental AllowInsecureHTTP use (#96)

[MINOR] The refusal error includes the full request URL (including query string) which may carry sensitive data in some edge cases; if upstream logs this error verbatim, it could leak information. Consider redacting query parameters or logging a sanitized URL.