Rodin rodin
  • Joined on 2026-04-23
rodin commented on pull request rodin/review-bot#152 2026-05-16 03:14:59 +00:00
fix(#150): add EvalSymlinks to validateDocmapPath — close dir-symlink bypass

Finding #1 (ACK-NOT-VALID): Acknowledged. The reviewer explicitly notes this is a known limitation of the os.SameFile pattern and that "no action is required" — the code comment already labels it defense-in-depth. No code change needed. (Ref: fix plan comment 27994)

rodin commented on pull request rodin/review-bot#152 2026-05-16 03:14:37 +00:00
fix(#150): add EvalSymlinks to validateDocmapPath — close dir-symlink bypass

Finding #1 (ACK-NOT-VALID): Acknowledged. The reviewer explicitly notes this is a known limitation of the os.SameFile pattern and that "no action is required" — the code comment already labels it defense-in-depth. No code change needed.

rodin commented on pull request rodin/review-bot#152 2026-05-16 03:11:01 +00:00
fix(#150): add EvalSymlinks to validateDocmapPath — close dir-symlink bypass

Finding #1 (ACK-NOT-VALID): Acknowledged. The reviewer explicitly notes this is a known limitation of the os.SameFile pattern and that "no action is required" — the code comment already labels it defense-in-depth. No code change needed.

rodin commented on pull request rodin/review-bot#152 2026-05-16 03:10:33 +00:00
fix(#150): add EvalSymlinks to validateDocmapPath — close dir-symlink bypass

Finding #1 (ACK-NOT-VALID): Acknowledged. The reviewer explicitly notes this is a known limitation of the os.SameFile pattern and that "no action is required" — the code comment already labels it defense-in-depth. No code change needed.

rodin commented on pull request rodin/review-bot#152 2026-05-16 03:06:40 +00:00
fix(#150): add EvalSymlinks to validateDocmapPath — close dir-symlink bypass

Finding #1 (ACK-NOT-VALID — Review #4814): The reviewer explicitly notes this is a known limitation of the os.SameFile pattern and states "no action is required." The code comment already labels this guard as defense-in-depth. No change needed.

rodin commented on pull request rodin/review-bot#152 2026-05-16 02:58:48 +00:00
fix(#150): add EvalSymlinks to validateDocmapPath — close dir-symlink bypass

Self-Review: PR #152

Self-review against eb0ff3aa69f152dd995de91c88227d3e32ac2917

Phase 1: Independent Findings

None — diff looks clean.

Reviewed validatedocmap.go and `validatedocmap_t…

rodin commented on pull request rodin/review-bot#152 2026-05-16 02:55:16 +00:00
fix(#150): add EvalSymlinks to validateDocmapPath — close dir-symlink bypass

Self-Review: PR #152

Self-review against eb0ff3aa69f152dd995de91c88227d3e32ac2917

Phase 1: Independent Findings

None — diff looks clean.

Reviewed validatedocmap.go and `validatedocma…

rodin commented on pull request rodin/review-bot#152 2026-05-16 02:50:45 +00:00
fix(#150): add EvalSymlinks to validateDocmapPath — close dir-symlink bypass

Self-Review: PR #152

Self-review against eb0ff3aa69f152dd995de91c88227d3e32ac2917

Phase 1: Independent Findings

None — diff looks clean.

Reviewed validatedocmap.go and `validatedocma…

rodin commented on pull request rodin/review-bot#152 2026-05-16 02:46:49 +00:00
fix(#150): add EvalSymlinks to validateDocmapPath — close dir-symlink bypass

Self-Review: PR #152

Self-review against eb0ff3aa69f152dd995de91c88227d3e32ac2917

Phase 1: Independent Findings

None — diff looks clean.

Reviewed validatedocmap.go and `validatedocmap_…

rodin commented on pull request rodin/review-bot#152 2026-05-16 02:42:28 +00:00
fix(#150): add EvalSymlinks to validateDocmapPath — close dir-symlink bypass

Self-Review: PR #152

Self-review against eb0ff3aa69f152dd995de91c88227d3e32ac2917

Phase 1: Independent Findings

None — diff looks clean.

Reviewed validatedocmap.go and `validatedocma…

rodin commented on pull request rodin/review-bot#152 2026-05-16 02:38:12 +00:00
fix(#150): add EvalSymlinks to validateDocmapPath — close dir-symlink bypass

Self-Review: PR #152

Self-review against eb0ff3aa69f152dd995de91c88227d3e32ac2917

Phase 1: Independent Findings

None — diff looks clean.

Reviewed validatedocmap.go and `validatedocmap…

rodin commented on pull request rodin/review-bot#152 2026-05-16 02:34:21 +00:00
fix(#150): add EvalSymlinks to validateDocmapPath — close dir-symlink bypass

Self-Review: PR #152

Self-review against eb0ff3aa69f152dd995de91c88227d3e32ac2917

Phase 1: Independent Findings

None — diff looks clean.

Reviewed validatedocmap.go and `validatedocmap_…

rodin commented on pull request rodin/review-bot#152 2026-05-16 02:30:48 +00:00
fix(#150): add EvalSymlinks to validateDocmapPath — close dir-symlink bypass

Self-Review: PR #152

Self-review against eb0ff3aa69f152dd995de91c88227d3e32ac2917

Phase 1: Independent Findings

None — diff looks clean.

Reviewed validatedocmap.go and `validatedocma…

rodin commented on pull request rodin/review-bot#152 2026-05-16 02:26:23 +00:00
fix(#150): add EvalSymlinks to validateDocmapPath — close dir-symlink bypass

Self-Review: PR #152

Self-review against eb0ff3aa69f152dd995de91c88227d3e32ac2917

Phase 1: Independent Findings

None — diff looks clean.

Reviewed validatedocmap.go and `validatedocmap_…

rodin commented on pull request rodin/review-bot#159 2026-05-16 02:19:27 +00:00
CI: gate heavy reviews on self-review (Doc consistency); comment-trigger; disable TTL heavy reviews

Self-Review: PR #159

Self-review against 951aa5d584a39f43c56e23c18021efa6cb18f45d

Phase 1: Independent Findings

This HEAD adds one commit on top of the previously-reviewed d1ce39bd:…

rodin pushed to ci-selfreview-gate at rodin/review-bot 2026-05-16 02:15:25 +00:00
951aa5d584 ci: add workflow-lint to sanity-check triggers and gates for ci.yml
rodin commented on pull request rodin/review-bot#159 2026-05-16 02:14:19 +00:00
CI: gate heavy reviews on self-review (Doc consistency); comment-trigger; disable TTL heavy reviews

Self-Review: PR #159

Self-review against d1ce39bd7b649fa1c66d94133bf00d217da2f4e2

Phase 1: Independent Findings

None — diff looks clean.

The single changed line:

- select(.body
rodin pushed to ci-selfreview-gate at rodin/review-bot 2026-05-16 01:51:00 +00:00
d1ce39bd7b fix(ci): escape regex \s and \b as JSON string literals in jq filter
rodin commented on pull request rodin/review-bot#159 2026-05-16 01:50:21 +00:00
CI: gate heavy reviews on self-review (Doc consistency); comment-trigger; disable TTL heavy reviews

Fix Plan against 97b688f95f79f3fb1d8005611327944e9cc42ed9:

What is broken

The review-gate CI job fails at the "Check self-review gate" step with:

jq: error: Invalid escape at line…
rodin pushed to ci-selfreview-gate at rodin/review-bot 2026-05-16 01:48:56 +00:00
97b688f95f ci: install jq in review-gate job to ensure JSON parsing succeeds