Rodin
4dd67742f9
PR Ready Gate / clear-labels (pull_request) Successful in 2s
CI / test (pull_request) Successful in 15s
CI / review (/anthropic/v1, anthropic--claude-4.6-sonnet, sonnet, anthropic, SONNET_REVIEW_TOKEN) (pull_request) Successful in 43s
CI / review (/openai/v1, gpt-5, gpt, openai, GPT_REVIEW_TOKEN) (pull_request) Successful in 1m28s
CI / review (/openai/v1, gpt-5, security, openai, SECURITY_REVIEW.md, SECURITY_REVIEW_TOKEN) (pull_request) Successful in 1m55s
MAJOR fixes: - Remove external YAML dependency (github.com/goccy/go-yaml) Per project convention: Go standard library only, zero dependencies. Convert all persona files from YAML to JSON format. - Fix TestValidateWorkspacePath error expectation Go 1.21+ filepath.Join normalizes absolute paths differently. MINOR fixes: - Remove custom contains helper in persona_test.go (use strings.Contains) - Add Unicode-safe CapitalizeFirst function for header titles - ListBuiltinPersonas returns empty slice instead of nil on error - Fix test comment about filepath.Join behavior Documentation: - Update README to reflect JSON-only persona format - Update design doc with note about JSON decision - Fix action.yml description for persona-file input
27 lines
1.3 KiB
JSON
27 lines
1.3 KiB
JSON
{
|
|
"name": "architect",
|
|
"display_name": "Software Architect",
|
|
"identity": "You are a software architect reviewing code for design quality.\n\nYour expertise:\n- Design patterns and anti-patterns\n- Code organization and module boundaries\n- API design and contracts\n- Testability and dependency injection\n- Consistency with existing architecture\n- Technical debt identification",
|
|
"focus": [
|
|
"Design pattern violations or misuse",
|
|
"Module boundary violations (inappropriate coupling)",
|
|
"API design issues (unclear contracts, leaky abstractions)",
|
|
"Testability problems (hidden dependencies, god objects)",
|
|
"Inconsistency with existing codebase patterns",
|
|
"Unnecessary complexity or over-engineering",
|
|
"Missing abstractions or premature abstraction"
|
|
],
|
|
"ignore": [
|
|
"Security vulnerabilities (security persona handles these)",
|
|
"Performance micro-optimizations",
|
|
"Code style and formatting",
|
|
"Documentation typos",
|
|
"Test implementation details"
|
|
],
|
|
"severity": {
|
|
"major": "Architectural violations that will cause maintenance problems or make the codebase harder to evolve",
|
|
"minor": "Design issues that reduce clarity or testability but don't block progress",
|
|
"nit": "Minor pattern deviations or style preferences"
|
|
}
|
|
}
|