Rodin
e234dca474
Major improvements to review quality: 1. Full file context: fetch complete content of all modified files from the PR branch and include as reference. This eliminates false-positive "missing import" findings since the model sees the entire file. 2. Patterns repo: new --patterns-repo / PATTERNS_REPO flag fetches language idiom files from a separate Gitea repo (e.g. rodin/elixir-patterns) and includes them as review criteria. 3. Multi-file patterns: --patterns-files / PATTERNS_FILES accepts comma-separated file paths to fetch from the patterns repo. New API methods: - GetPullRequestFiles: list changed files in a PR - GetFileContentRef: fetch file content from a specific branch/ref Prompt changes: - BuildSystemPrompt now accepts (conventions, patterns) - BuildUserPrompt now accepts fileContext parameter - File context displayed before diff for model reference - Patterns presented as "review criteria" in system prompt Composite action updated with patterns-repo and patterns-files inputs.
87 lines
3.7 KiB
Go
87 lines
3.7 KiB
Go
package review
|
|
|
|
import (
|
|
"fmt"
|
|
"strings"
|
|
)
|
|
|
|
// BuildSystemPrompt constructs the system prompt for the LLM reviewer.
|
|
func BuildSystemPrompt(conventions, patterns string) string {
|
|
var sb strings.Builder
|
|
|
|
sb.WriteString("You are an expert code reviewer. Review the provided pull request diff carefully.\n\n")
|
|
sb.WriteString("CONTEXT:\n")
|
|
sb.WriteString("- You will receive the full content of modified files for reference, followed by the diff showing what changed.\n")
|
|
sb.WriteString("- The diff shows ONLY what was added/removed. The full file content provides complete context.\n")
|
|
sb.WriteString("- Focus your review on the CHANGES (the diff), using the full files for context.\n\n")
|
|
sb.WriteString("Your task:\n")
|
|
sb.WriteString("1. Review the diff for correctness, idiomatic code, potential bugs, and design issues.\n")
|
|
sb.WriteString("2. Consider the CI status — if CI has failed, that is an automatic REQUEST_CHANGES regardless of code quality.\n")
|
|
sb.WriteString("3. Output your review as structured JSON (and ONLY JSON, no markdown fences or other text).\n\n")
|
|
sb.WriteString("Output format:\n")
|
|
sb.WriteString("{\n")
|
|
sb.WriteString(" \"verdict\": \"APPROVE\" or \"REQUEST_CHANGES\",\n")
|
|
sb.WriteString(" \"summary\": \"Brief overall assessment (1-3 sentences)\",\n")
|
|
sb.WriteString(" \"findings\": [\n")
|
|
sb.WriteString(" {\n")
|
|
sb.WriteString(" \"severity\": \"MAJOR\" or \"MINOR\" or \"NIT\",\n")
|
|
sb.WriteString(" \"file\": \"path/to/file\",\n")
|
|
sb.WriteString(" \"line\": <line number from the diff>,\n")
|
|
sb.WriteString(" \"finding\": \"Description of the issue\"\n")
|
|
sb.WriteString(" }\n")
|
|
sb.WriteString(" ],\n")
|
|
sb.WriteString(" \"recommendation\": \"Full recommendation text explaining your verdict\"\n")
|
|
sb.WriteString("}\n\n")
|
|
sb.WriteString("Rules:\n")
|
|
sb.WriteString("- If there are any MAJOR findings → verdict must be REQUEST_CHANGES\n")
|
|
sb.WriteString("- If there are no MAJOR findings → verdict should be APPROVE\n")
|
|
sb.WriteString("- If CI has failed → verdict must be REQUEST_CHANGES with a finding noting the CI failure\n")
|
|
sb.WriteString("- Be thorough but fair. Don't nitpick style unless it impacts readability significantly.\n")
|
|
sb.WriteString("- Line numbers should reference the new file line numbers from the diff headers.\n")
|
|
sb.WriteString("- If the diff is empty or trivial (only formatting/whitespace), APPROVE with no findings.\n")
|
|
|
|
if patterns != "" {
|
|
sb.WriteString(fmt.Sprintf("\n\n## Language Patterns & Idioms\n\nUse the following patterns as review criteria. Code that violates these established patterns is a finding:\n\n%s\n", patterns))
|
|
}
|
|
|
|
if conventions != "" {
|
|
sb.WriteString(fmt.Sprintf("\n\n## Repository Conventions\n\nThe repository has the following coding conventions that must be respected:\n\n%s\n", conventions))
|
|
}
|
|
|
|
return sb.String()
|
|
}
|
|
|
|
// BuildUserPrompt constructs the user message with PR context.
|
|
func BuildUserPrompt(title, description, diff, fileContext string, ciPassed bool, ciDetails string) string {
|
|
var sb strings.Builder
|
|
|
|
sb.WriteString(fmt.Sprintf("## Pull Request: %s\n\n", title))
|
|
|
|
if description != "" {
|
|
sb.WriteString(fmt.Sprintf("### Description\n%s\n\n", description))
|
|
}
|
|
|
|
ciStatus := "PASSED"
|
|
if !ciPassed {
|
|
ciStatus = "FAILED"
|
|
}
|
|
sb.WriteString(fmt.Sprintf("### CI Status: %s\n", ciStatus))
|
|
|
|
if ciDetails != "" {
|
|
sb.WriteString(fmt.Sprintf("CI Details: %s\n", ciDetails))
|
|
}
|
|
|
|
if fileContext != "" {
|
|
sb.WriteString("\n### Full File Context (modified files)\n\n")
|
|
sb.WriteString(fileContext)
|
|
sb.WriteString("\n")
|
|
}
|
|
|
|
sb.WriteString("\n### Diff (changes to review)\n\n")
|
|
sb.WriteString("```diff\n")
|
|
sb.WriteString(diff)
|
|
sb.WriteString("\n```\n")
|
|
|
|
return sb.String()
|
|
}
|