claw
ce48dc0ec6
CI / test (pull_request) Successful in 16s
CI / review (anthropic--claude-4.6-sonnet, sonnet, SONNET_REVIEW_TOKEN) (pull_request) Successful in 43s
CI / review (gpt-5, security, ., rodin/security-patterns, SECURITY_REVIEW.md, SECURITY_REVIEW_TOKEN) (pull_request) Successful in 58s
CI / review (gpt-5, gpt, GPT_REVIEW_TOKEN) (pull_request) Successful in 1m22s
Add defense-in-depth for the AllowInsecureHTTP client option: 1. HTTPS enforcement: doRequest now rejects non-HTTPS URLs when credentials are present and insecure mode is not explicitly enabled. 2. Environment gate: AllowInsecureHTTP() requires REVIEW_BOT_ALLOW_INSECURE=1 env var. Without it, the option is silently ignored and a warning is logged. This prevents accidental enablement from config drift. 3. Warning on activation: When the env gate IS satisfied, a slog.Warn fires at client construction time so operators notice in logs. 4. Test bypass: AllowInsecureHTTPForTest() skips the env gate for test convenience with httptest.Server, keeping tests clean. Closes #96