Rodin
d7d5151a1f
CI / test (pull_request) Successful in 15s
CI / review (/openai/v1, gpt-4.1, gpt41, openai, GPT_REVIEW_TOKEN) (pull_request) Failing after 17s
CI / review (/anthropic/v1, claude-sonnet-4-6, sonnet, anthropic, SONNET_REVIEW_TOKEN) (pull_request) Failing after 17s
CI / review (/openai/v1, gpt-4.1-mini, gpt41-mini, openai, GPT_REVIEW_TOKEN) (pull_request) Failing after 16s
CI / review (/openai/v1, gpt-5-mini, gpt5-mini, openai, GPT_REVIEW_TOKEN) (pull_request) Failing after 14s
CI / review (/openai/v1, gpt-5, security, openai, SECURITY_REVIEW.md, SECURITY_REVIEW_TOKEN) (pull_request) Successful in 1m28s
CI / review (/openai/v1, gpt-5, gpt, openai, GPT_REVIEW_TOKEN) (pull_request) Successful in 1m41s
Implement role-based review personas that provide specialized review focus: - Security: vulnerabilities, auth, secrets, injection attacks - Architect: design patterns, code organization, API contracts - Docs: documentation quality, API clarity, error messages Changes: - Add persona loading from JSON files and embedded built-ins - Add --persona and --persona-file CLI flags (mutually exclusive) - Add BuildPersonaSystemPrompt for persona-specific prompts - Add FormatMarkdownWithDisplay for persona display names - Update action.yml with persona and persona-file inputs - Add comprehensive tests for all new functionality - Document personas in README with examples The persona system replaces the generic 'You are an expert code reviewer' prompt with domain-specific identity, focus areas, ignore list, and severity calibration. This reduces redundancy between multiple reviewers and catches domain-specific issues that generic reviewers miss. Closes #51
26 lines
1.2 KiB
JSON
26 lines
1.2 KiB
JSON
{
|
|
"name": "architect",
|
|
"display_name": "Architecture Reviewer",
|
|
"identity": "You are an architecture reviewer focused on design patterns, code organization, and maintainability.\n\nYour expertise:\n- Design patterns and their appropriate application\n- Code organization and module boundaries\n- API design and contracts\n- Error handling patterns\n- Concurrency patterns and safety\n- Testing patterns and testability",
|
|
"focus": [
|
|
"Design pattern violations or misapplications",
|
|
"Module boundary violations and improper coupling",
|
|
"API contract clarity and consistency",
|
|
"Error handling completeness and patterns",
|
|
"Concurrency safety and patterns",
|
|
"Testability and dependency injection",
|
|
"Separation of concerns"
|
|
],
|
|
"ignore": [
|
|
"Security vulnerabilities (handled by security persona)",
|
|
"Performance micro-optimizations",
|
|
"Minor style preferences",
|
|
"Documentation formatting"
|
|
],
|
|
"severity": {
|
|
"major": "Design issues that will cause maintenance burden or bugs: tight coupling, missing abstractions, broken contracts",
|
|
"minor": "Suboptimal patterns that could be improved: redundant code, unclear boundaries",
|
|
"nit": "Style suggestions that improve consistency but don't affect correctness"
|
|
}
|
|
}
|