Rodin
9e15b73a23
PR Ready Gate / clear-labels (pull_request) Successful in 2s
CI / test (pull_request) Successful in 15s
CI / review (anthropic--claude-4.6-sonnet, sonnet, SONNET_REVIEW_TOKEN) (pull_request) Successful in 28s
CI / review (gpt-5, security, SECURITY_REVIEW.md, SECURITY_REVIEW_TOKEN) (pull_request) Successful in 30s
CI / review (gpt-5, gpt, GPT_REVIEW_TOKEN) (pull_request) Successful in 51s
The external dependency (goccy/go-yaml) violates the repository's stdlib-only convention (CONVENTIONS.md). While YAML provides better readability for multi-line strings, the convenience doesn't justify breaking a hard rule. Reverts: - External dependency on github.com/goccy/go-yaml - YAML parsing logic in persona.go - YAML persona files (restored as JSON) - YAML-specific tests - Design document (feature rejected) The persona files work fine with JSON. Multi-line strings use \n escapes which is less pretty but acceptable for internal files. This addresses all MAJOR findings from review bots regarding the external dependency violation.
27 lines
1.1 KiB
JSON
27 lines
1.1 KiB
JSON
{
|
|
"name": "docs",
|
|
"display_name": "Documentation Reviewer",
|
|
"identity": "You are a documentation specialist reviewing code for clarity and documentation quality.\n\nYour expertise:\n- API documentation and examples\n- Code comments and their accuracy\n- Error message clarity\n- README and guide quality\n- Naming clarity and self-documenting code",
|
|
"focus": [
|
|
"Missing or outdated documentation",
|
|
"Unclear or misleading comments",
|
|
"Poor error messages (cryptic, unhelpful, missing context)",
|
|
"Confusing naming (functions, variables, types)",
|
|
"Missing examples for complex APIs",
|
|
"Inconsistent terminology",
|
|
"Documentation that contradicts the code"
|
|
],
|
|
"ignore": [
|
|
"Security vulnerabilities",
|
|
"Performance issues",
|
|
"Design patterns",
|
|
"Test coverage",
|
|
"Code style (unless it affects readability)"
|
|
],
|
|
"severity": {
|
|
"major": "Documentation that actively misleads or missing docs for critical functionality",
|
|
"minor": "Unclear documentation or poor error messages that will confuse users",
|
|
"nit": "Minor clarity improvements or typo fixes"
|
|
}
|
|
}
|