claw 86beba63da fix(github): add pagination tests and fix truncation warning logic ...

F1: Add comprehensive pagination tests for ListReviews covering:
- Multi-page behaviour (2 full + 1 partial page)
- Exact-multiple-of-pageSize (extra empty-page round-trip)
- maxReviewPages cutoff (cap hit, results still returned)
- Empty first page (PR with no reviews)

F2: Fix truncation warning logic by moving it outside the loop with
a 'truncated' flag. Previously, the warning fired inline at page==maxPages
which could miss the case where the short-page break fires first on the
cap page. Now it only fires when the loop exits because the cap was reached
and the last page was full (indicating more data likely exists).

Also adds SetReviewPagination to Client for test-time override of page
size and max pages, following the existing SetRetryBackoff pattern.

2026-05-13 16:03:01 -07:00

..

client_test.go

fix(github): remove double blank line in client_test.go (gofmt)

2026-05-13 08:48:09 -07:00

client.go

fix(github): add pagination tests and fix truncation warning logic

2026-05-13 16:03:01 -07:00

conformance_test.go

fix: address review feedback - eliminate type assertion via ReviewSuperseder interface

2026-05-13 09:03:42 -07:00

files_test.go

fix(test): SetRetryBackoff with correct slice length

2026-05-12 22:47:31 -07:00

files.go

feat(github): implement FileReader interface (#80)

2026-05-13 05:33:30 +00:00

helpers_test.go

fix(github): validate conflicting commit IDs and extract test helper

2026-05-13 13:18:46 +00:00

identity_test.go

feat(github): implement Reviewer and Identity interfaces (#81)

2026-05-13 13:18:46 +00:00

pr_test.go

fix: address review feedback on PR #102

2026-05-13 04:47:15 +00:00

pr.go

fix: address review feedback on PRReader implementation

2026-05-12 22:17:32 -07:00

review_test.go

fix(github): add pagination tests and fix truncation warning logic

2026-05-13 16:03:01 -07:00

reviews.go

fix(github): add pagination tests and fix truncation warning logic

2026-05-13 16:03:01 -07:00