claw
359f73c395
- Extract named HeadRef and UserInfo structs from anonymous structs in PullRequest and Review (comments 16615, 16616) - Change ReviewEventApprove value from "APPROVED" to "APPROVE" to represent the action, not the state; document adapter translation responsibility (comment 16621) - Add doc comment on ReviewComment.CommitID noting optionality (16531) - Move compile-time assertion from check.go (//go:build ignore) to check_test.go with a "phase2" build tag — removes gitea adapter import from the vcs package (comment 16622) - check.go misleading comment was already fixed in prior commit (16532, 16539) - Sha→SHA, typed ReviewEvent, duplicate package doc already resolved (16537, 16538, 16530)
28 lines
1.1 KiB
Go
28 lines
1.1 KiB
Go
//go:build phase2
|
|
|
|
package vcs_test
|
|
|
|
import (
|
|
"gitea.weiker.me/rodin/review-bot/gitea"
|
|
"gitea.weiker.me/rodin/review-bot/vcs"
|
|
)
|
|
|
|
// Compile-time assertion: documents the gap between gitea.Client and vcs.Client.
|
|
// Guarded by the "phase2" build tag — enable once the Gitea adapter bridges these gaps:
|
|
//
|
|
// 1. PostReview signature mismatch:
|
|
// gitea.Client: PostReview(ctx, owner, repo, number, event, body string, comments []gitea.ReviewComment)
|
|
// vcs.Reviewer: PostReview(ctx, owner, repo, number, req vcs.ReviewRequest)
|
|
//
|
|
// 2. GetFileContent signature mismatch:
|
|
// gitea.Client: GetFileContent(ctx, owner, repo, filepath string) [no ref; uses default branch]
|
|
// vcs.FileReader: GetFileContent(ctx, owner, repo, path, ref string)
|
|
// (gitea.Client has GetFileContentRef for the ref variant)
|
|
//
|
|
// 3. ReviewComment type mismatch:
|
|
// gitea.ReviewComment uses NewPosition int64 (Gitea line-number convention)
|
|
// vcs.ReviewComment uses Position int (GitHub diff-position convention)
|
|
//
|
|
// The Gitea adapter (Phase 2) will wrap gitea.Client to bridge these gaps.
|
|
var _ vcs.Client = (*gitea.Client)(nil)
|