rodin/review-bot
2
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 6 Wiki Activity

feat: add native SAP AI Core support #50

Closed
rodin wants to merge 12 commits from feat/aicore-provider into main
pull from: feat/aicore-provider
merge into: rodin:main
Conversation 27 Commits 12 Files Changed 8
+3 -3
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 44c80c36cf - Show all commits
llm/aicore.go
+1 -1
View File
49
 @@ -253,7 +253,7 @@ func (c *AICoreClient) CompleteAnthropic(ctx context.Context, model string, mess
} }
reqBody := anthropicRequest{ reqBody := anthropicRequest{
// AnthropicVersion omitted - SAP AI Core does not accept it in body AnthropicVersion: "bedrock-2023-05-31", // SAP AI Core uses Bedrock format
// Model omitted - AI Core deployment already specifies model // Model omitted - AI Core deployment already specifies model
MaxTokens: maxTokens, MaxTokens: maxTokens,
System: system, System: system,
24
llm/aicore_test.go
+2 -2
View File
4
 @@ -206,8 +206,8 @@ func TestAICoreClient_CompleteAnthropic(t *testing.T) {
if err := json.NewDecoder(r.Body).Decode(&req); err != nil { if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
t.Fatalf("decode request: %v", err) t.Fatalf("decode request: %v", err)
} }
if req.MaxTokens == 0 { if req.AnthropicVersion != "bedrock-2023-05-31" {
t.Errorf("expected max_tokens in request") t.Errorf("expected bedrock anthropic_version in request")
} }
if req.System != "You are helpful" { if req.System != "You are helpful" {
t.Errorf("expected system prompt: %q", req.System) t.Errorf("expected system prompt: %q", req.System)
3