rodin/review-bot
2
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 6 Wiki Activity

fix: trim trailing slash from giteaURL when building review link #40

Merged
rodin merged 1 commits from fix/url-normalization into main 2026-05-02 18:52:14 +00:00
Conversation 3 Commits 1 Files Changed 1
+1 -1
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cmd/review-bot/main.go
+1 -1
View File
@@ -355,7 +355,7 @@ func main() {
// Supersede old review with link to the new one // Supersede old review with link to the new one
if existingReview != nil && existingCommentID > 0 { if existingReview != nil && existingCommentID > 0 {
newReviewURL := fmt.Sprintf("%s/%s/%s/pulls/%d#pullrequestreview-%d", *giteaURL, owner, repoName, prNumber, posted.ID) newReviewURL := fmt.Sprintf("%s/%s/%s/pulls/%d#pullrequestreview-%d", strings.TrimRight(*giteaURL, "/"), owner, repoName, prNumber, posted.ID)
supersededBody := buildSupersededBody(existingReview.Body, existingReview.CommitID, newReviewURL, sentinel) supersededBody := buildSupersededBody(existingReview.Body, existingReview.CommitID, newReviewURL, sentinel)
if err := giteaClient.EditComment(ctx, owner, repoName, existingCommentID, supersededBody); err != nil { if err := giteaClient.EditComment(ctx, owner, repoName, existingCommentID, supersededBody); err != nil {
slog.Warn("could not mark old review as superseded", "comment_id", existingCommentID, "error", err) slog.Warn("could not mark old review as superseded", "comment_id", existingCommentID, "error", err)