rodin/review-bot
2
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 6 Wiki Activity

test(#146): add TestMainSubprocess_InvalidDocMapPath and TestMainSubprocess_InvalidDocMapFile #151

Merged
rodin merged 1 commits from issue-146 into main 2026-05-15 12:07:28 +00:00
Conversation 17 Commits 1 Files Changed 1
+4
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cmd/review-bot/main_test.go
+4
View File
1
 @@ -1521,6 +1521,8 @@ func TestMainSubprocess_InvalidDocMapPath(t *testing.T) {
} }
cmd := exec.Command(os.Args[0], "-test.run=TestMainSubprocess_InvalidDocMapPath") cmd := exec.Command(os.Args[0], "-test.run=TestMainSubprocess_InvalidDocMapPath")
// t.TempDir() is evaluated here in the outer process, producing a real directory
// that is passed as the GITHUB_WORKSPACE env var string to the subprocess.
cmd.Env = append(cleanEnv(), cmd.Env = append(cleanEnv(),
"TEST_SUBPROCESS_MAIN=1", "TEST_SUBPROCESS_MAIN=1",
"GITHUB_WORKSPACE="+t.TempDir(), "GITHUB_WORKSPACE="+t.TempDir(),
sonnet-review-bot commented 2026-05-15 12:00:08 +00:00
Outdated
Review
Copy Link
Copy Source

[NIT] The comment // t.TempDir() is evaluated here in the outer process, producing a real directory / that is passed as the GITHUB_WORKSPACE env var string to the subprocess. is duplicated verbatim in both new test functions. It's accurate and useful, but could be a shared helper (e.g. workspaceEnv(t)) to avoid repeating the same comment+pattern four times total (two existing tests already use similar patterns). Minor — not worth blocking.

**[NIT]** The comment `// t.TempDir() is evaluated here in the outer process, producing a real directory / that is passed as the GITHUB_WORKSPACE env var string to the subprocess.` is duplicated verbatim in both new test functions. It's accurate and useful, but could be a shared helper (e.g. `workspaceEnv(t)`) to avoid repeating the same comment+pattern four times total (two existing tests already use similar patterns). Minor — not worth blocking.
1
 @@ -1558,6 +1560,8 @@ func TestMainSubprocess_InvalidDocMapFile(t *testing.T) {
} }
cmd := exec.Command(os.Args[0], "-test.run=TestMainSubprocess_InvalidDocMapFile") cmd := exec.Command(os.Args[0], "-test.run=TestMainSubprocess_InvalidDocMapFile")
// t.TempDir() is evaluated here in the outer process, producing a real directory
// that is passed as the GITHUB_WORKSPACE env var string to the subprocess.
cmd.Env = append(cleanEnv(), cmd.Env = append(cleanEnv(),
"TEST_SUBPROCESS_MAIN=1", "TEST_SUBPROCESS_MAIN=1",
"GITHUB_WORKSPACE="+t.TempDir(), "GITHUB_WORKSPACE="+t.TempDir(),