rodin/review-bot
2
1
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases 6 Wiki Activity

docs(#148): add SKILL.md and dev-loop-spec.md for dispatch redesign #149

Merged
rodin merged 3 commits from issue-148 into main 2026-05-15 08:12:02 +00:00
Conversation 12 Commits 3 Files Changed 2
+4 -2
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 151199e436 - Show all commits
SKILL.md
+2 -1
View File
9
 @@ -53,7 +53,7 @@ The model **never** assesses project state or makes dispatch decisions.
| 8 | Unacknowledged bot review findings | SPAWN:address-feedback |
| 9 | Unresolved inline diff comments | SPAWN:address-feedback |
| 10 | All checks pass | HANDOFF |
| 10 | No open PRs + no ACTIVE_WIP | SPAWN:impl (next issue) |
| 11 | No open PRs + no ACTIVE_WIP | SPAWN:impl (next issue) |
gpt-review-bot commented 2026-05-15 07:46:59 +00:00
Outdated
Review
Copy Link
Copy Source

[MINOR] Dispatch rules table duplicates rule number 10 for two different actions; the second should be rule 11 (new issue pickup) to match the spec in docs/dev-loop-spec.md.

**[MINOR]** Dispatch rules table duplicates rule number 10 for two different actions; the second should be rule 11 (new issue pickup) to match the spec in docs/dev-loop-spec.md.
## Files
@@ -61,6 +61,7 @@ The model **never** assesses project state or makes dispatch decisions.
|------|-------------|
| `~/.openclaw/workspace/scripts/dev-loop-dispatch.sh` | Dispatch script — pure bash |
| `~/.openclaw/workspace/scripts/worker-tasks/self-review.md` | Self-review worker template |
| `~/.openclaw/workspace/scripts/worker-tasks/sr-fix.md` | Fix findings from self-review |
| `~/.openclaw/workspace/scripts/worker-tasks/ci-fix.md` | CI fix worker template |
| `~/.openclaw/workspace/scripts/worker-tasks/address-feedback.md` | Address feedback worker template |
| `~/.openclaw/workspace/scripts/worker-tasks/findings.md` | Address REQUEST_CHANGES findings |
2
docs/dev-loop-spec.md
+2 -1
View File
9
 @@ -254,6 +254,7 @@ Each worker receives a precise task description with substituted values:
| Template | Trigger | Key job |
|----------|---------|---------|
| `self-review.md` | No clean self-review | Post self-review comment, remove WIP |
| `sr-fix.md` | Self-review needs attention | Address self-review findings, push, remove WIP |
| `ci-fix.md` | CI failing | Diagnose, fix, push, remove WIP |
sonnet-review-bot commented 2026-05-15 07:46:14 +00:00
Review
Copy Link
Copy Source

[NIT] Section 9 references scripts/check-deps.sh as the tool that verifies invariant S1, but the script is described as test/check-invariants.sh in Section 6 and throughout SKILL.md. This appears to be a stale reference — should be test/check-invariants.sh.

**[NIT]** Section 9 references `scripts/check-deps.sh` as the tool that verifies invariant S1, but the script is described as `test/check-invariants.sh` in Section 6 and throughout SKILL.md. This appears to be a stale reference — should be `test/check-invariants.sh`.
| `address-feedback.md` | Unacknowledged findings or inline comments | Address feedback, push, remove WIP |
| `findings.md` | REQUEST_CHANGES present | Address REQUEST_CHANGES, push, remove WIP |
gpt-review-bot commented 2026-05-15 07:46:59 +00:00
Review
Copy Link
Copy Source

[MINOR] Reference to scripts/check-deps.sh verifying invariant S1 appears incorrect/inconsistent; earlier sections and SKILL.md refer to ~/.openclaw/workspace/scripts/test/check-invariants.sh for invariant checks. Update to the correct script path/name.

**[MINOR]** Reference to scripts/check-deps.sh verifying invariant S1 appears incorrect/inconsistent; earlier sections and SKILL.md refer to ~/.openclaw/workspace/scripts/test/check-invariants.sh for invariant checks. Update to the correct script path/name.
@@ -267,7 +268,7 @@ Workers **always** remove the WIP label on completion and reply `NO_REPLY`.
## 9. Fixes for Issues #144 and #145
**Issue #144** (autonomous merge):
The dispatch script contains no merge API calls anywhere. The `scripts/check-deps.sh`
The dispatch script contains no merge API calls anywhere. The `scripts/test/check-invariants.sh`
gpt-review-bot commented 2026-05-15 07:48:41 +00:00
Outdated
Review
Copy Link
Copy Source

[NIT] Invariants checker path differs from earlier mention (line 222). Unify the path formatting to avoid ambiguity for readers.

**[NIT]** Invariants checker path differs from earlier mention (line 222). Unify the path formatting to avoid ambiguity for readers.
invariant `S1` verifies this. Workers do not receive merge instructions.
**Issue #145** (merged despite REQUEST_CHANGES):