rodin/review-bot
2
1
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases 6 Wiki Activity

feat(vcs): add CommitID to ReviewRequest (#115) #118

Merged
aweiker merged 5 commits from review-bot-issue-115 into feature/github-support 2026-05-14 01:49:33 +00:00
Conversation 47 Commits 5 Files Changed 4
+1
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 49db84fb82 - Show all commits
gitea/adapter_test.go
+1
View File
1
 @@ -247,6 +247,7 @@ func TestAdapter_PostReview_CommitID(t *testing.T) {
t.Errorf("expected commit_id %q forwarded to client, got %q", "sha256abc", gotCommitID)
}
}
func TestAdapter_PostReview_WithComments_PositionTranslation(t *testing.T) {
diff := `diff --git a/main.go b/main.go
sonnet-review-bot commented 2026-05-13 21:04:27 +00:00
Outdated
Review
Copy Link
Copy Source

[NIT] Missing blank line between TestAdapter_PostReview_CommitID and TestAdapter_PostReview_WithComments_PositionTranslation. Minor style inconsistency — all other test functions in the file have a blank line separator.

**[NIT]** Missing blank line between `TestAdapter_PostReview_CommitID` and `TestAdapter_PostReview_WithComments_PositionTranslation`. Minor style inconsistency — all other test functions in the file have a blank line separator.
--- a/main.go
sonnet-review-bot commented 2026-05-13 20:37:01 +00:00
Outdated
Review
Copy Link
Copy Source

[NIT] Double blank line between TestAdapter_PostReview_EventTranslation and TestAdapter_PostReview_CommitID. Go convention (enforced by gofmt) uses a single blank line between top-level declarations. This also appears at the end of the TestPostReview_EmptyCommitID_OmittedFromPayload function in gitea/client_test.go (double blank before TestGetPullRequest_Non200).

**[NIT]** Double blank line between `TestAdapter_PostReview_EventTranslation` and `TestAdapter_PostReview_CommitID`. Go convention (enforced by gofmt) uses a single blank line between top-level declarations. This also appears at the end of the `TestPostReview_EmptyCommitID_OmittedFromPayload` function in `gitea/client_test.go` (double blank before `TestGetPullRequest_Non200`).