rodin/review-bot
2
1
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases 6 Wiki Activity

URL-escape file paths and refs in Gitea client #7

New Issue
Closed
opened 2026-05-01 19:23:37 +00:00 by rodin · 0 comments
rodin commented 2026-05-01 19:23:37 +00:00
Owner
Copy Link
Copy Source

Problem

GetFileContentRef and GetPullRequestFiles build URLs via fmt.Sprintf without escaping paths or refs. If paths contain special characters (#, ?, spaces), the URL breaks.

Fix

Use url.PathEscape for file paths and url.QueryEscape for ref params in all Gitea client methods that accept user-provided paths.

## Problem `GetFileContentRef` and `GetPullRequestFiles` build URLs via `fmt.Sprintf` without escaping paths or refs. If paths contain special characters (`#`, `?`, spaces), the URL breaks. ## Fix Use `url.PathEscape` for file paths and `url.QueryEscape` for ref params in all Gitea client methods that accept user-provided paths.
rodin referenced this issue from a commit 2026-05-01 21:19:38 +00:00
fix: quick wins (#7, #9, #13)
rodin closed this issue 2026-05-01 21:30:58 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai-review
bug
needs-review
ready
Ready for human review
 self-reviewed
Self-review passed since last push
 wip
Work in progress - do not start new work on this PR
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
security-review-bot rodin (Rodin)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: rodin/review-bot#7
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?