rodin/review-bot
2
1
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases 6 Wiki Activity

Consistent url.PathEscape across all Gitea client endpoints #24

New Issue
Closed
opened 2026-05-02 04:02:36 +00:00 by rodin · 0 comments
rodin commented 2026-05-02 04:02:36 +00:00
Owner
Copy Link
Copy Source

Problem

Some endpoints (ListReviews, DeleteReview) use url.PathEscape for owner/repo path segments while others (GetPullRequest, GetPullRequestDiff, PostReview) interpolate raw values directly.

This inconsistency has been flagged in 3 separate reviews now.

Fix

Audit all methods in gitea/client.go and apply url.PathEscape to owner/repo (and any other user-supplied path segments) consistently across every endpoint.

Risk

Low — for typical owner/repo names this is a no-op. Only matters for names with special characters (spaces, slashes, unicode). But consistency eliminates an entire class of potential bugs.

Context

Flagged as [NIT] or [MINOR] in PRs #17, #20, and #22 by multiple reviewers.

## Problem Some endpoints (ListReviews, DeleteReview) use `url.PathEscape` for owner/repo path segments while others (GetPullRequest, GetPullRequestDiff, PostReview) interpolate raw values directly. This inconsistency has been flagged in 3 separate reviews now. ## Fix Audit all methods in `gitea/client.go` and apply `url.PathEscape` to owner/repo (and any other user-supplied path segments) consistently across every endpoint. ## Risk Low — for typical `owner/repo` names this is a no-op. Only matters for names with special characters (spaces, slashes, unicode). But consistency eliminates an entire class of potential bugs. ## Context Flagged as [NIT] or [MINOR] in PRs #17, #20, and #22 by multiple reviewers.
rodin closed this issue 2026-05-02 14:01:53 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai-review
bug
needs-review
ready
Ready for human review
 self-reviewed
Self-review passed since last push
 wip
Work in progress - do not start new work on this PR
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
security-review-bot rodin (Rodin)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: rodin/review-bot#24
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?