rodin/review-bot
2
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 6 Wiki Activity

Make REQUEST_CHANGES threshold configurable #15

New Issue
Closed
opened 2026-05-01 19:47:20 +00:00 by rodin · 1 comment
rodin commented 2026-05-01 19:47:20 +00:00
Owner
Copy Link
Copy Source

Problem

Currently the threshold is hardcoded in the system prompt: any MAJOR finding → REQUEST_CHANGES, no MAJORs → APPROVE. Different teams may want different thresholds.

Proposed Solution

Add a --threshold / REVIEW_THRESHOLD option with values like:

  • strict — any finding (MAJOR, MINOR, or NIT) triggers REQUEST_CHANGES
  • major — only MAJOR findings trigger REQUEST_CHANGES (current default)
  • lenient — never REQUEST_CHANGES, always APPROVE with findings noted

The threshold is injected into the system prompt rules section.

Use Cases

  • strict: gargoyle (zero findings policy)
  • major: general repos (only block on real issues)
  • lenient: early-stage repos where reviews are advisory only
## Problem Currently the threshold is hardcoded in the system prompt: any MAJOR finding → REQUEST_CHANGES, no MAJORs → APPROVE. Different teams may want different thresholds. ## Proposed Solution Add a `--threshold` / `REVIEW_THRESHOLD` option with values like: - `strict` — any finding (MAJOR, MINOR, or NIT) triggers REQUEST_CHANGES - `major` — only MAJOR findings trigger REQUEST_CHANGES (current default) - `lenient` — never REQUEST_CHANGES, always APPROVE with findings noted The threshold is injected into the system prompt rules section. ## Use Cases - **strict**: gargoyle (zero findings policy) - **major**: general repos (only block on real issues) - **lenient**: early-stage repos where reviews are advisory only
rodin commented 2026-05-02 19:08:00 +00:00
Author
Owner
Copy Link
Copy Source

Closing — this is configurable via --system-prompt-file. The default prompt defines the threshold ("any MAJOR → REQUEST_CHANGES"), and per-repo overrides can redefine severity rules. No code change needed.

Closing — this is configurable via `--system-prompt-file`. The default prompt defines the threshold ("any MAJOR → REQUEST_CHANGES"), and per-repo overrides can redefine severity rules. No code change needed.
rodin closed this issue 2026-05-02 19:08:00 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai-review
bug
needs-review
ready
Ready for human review
 self-reviewed
Self-review passed since last push
 wip
Work in progress - do not start new work on this PR
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
security-review-bot rodin (Rodin)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: rodin/review-bot#15