rodin/review-bot
2
1
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases 6 Wiki Activity

PR #131: integration test not extended for GitHub (issue #130 acceptance criterion) #133

New Issue
Closed
opened 2026-05-14 22:16:03 +00:00 by rodin · 0 comments
rodin commented 2026-05-14 22:16:03 +00:00
Owner
Copy Link
Copy Source

What was missed

Issue #130 required the integration test to be updated or extended for GitHub. PR #131 did not add any GitHub-specific integration test coverage. The cmd/review-bot/integration_test.go file still only exercises the Gitea path — it reads INTEGRATION_GITEA_TOKEN and INTEGRATION_GITEA_REPO but has no equivalent INTEGRATION_GITHUB_TOKEN / INTEGRATION_GITHUB_REPO path, and VCS_TYPE is not set anywhere in the test.

Source

  • PR: #131 — feat: implement GitHub API methods and VCS routing (issue #130)
  • Linked issue: #130 — feat: implement GitHub API methods for PR review
  • Checklist section: Acceptance Criteria — "Integration test updated/extended for GitHub"

What needs to happen

  • Add a GitHub integration test path in cmd/review-bot/integration_test.go (or a new integration_github_test.go) that, when INTEGRATION_GITHUB_TOKEN and INTEGRATION_GITHUB_REPO env vars are set, exercises the full review-bot flow against a real GitHub PR using VCS_TYPE=github.
  • The test must skip gracefully when the env vars are absent.
  • The test must verify that PostReview succeeds and that the correct adapter is selected.

References

## What was missed Issue #130 required the integration test to be updated or extended for GitHub. PR #131 did not add any GitHub-specific integration test coverage. The `cmd/review-bot/integration_test.go` file still only exercises the Gitea path — it reads `INTEGRATION_GITEA_TOKEN` and `INTEGRATION_GITEA_REPO` but has no equivalent `INTEGRATION_GITHUB_TOKEN` / `INTEGRATION_GITHUB_REPO` path, and `VCS_TYPE` is not set anywhere in the test. ## Source - PR: #131 — feat: implement GitHub API methods and VCS routing (issue #130) - Linked issue: #130 — feat: implement GitHub API methods for PR review - Checklist section: Acceptance Criteria — "Integration test updated/extended for GitHub" ## What needs to happen - Add a GitHub integration test path in `cmd/review-bot/integration_test.go` (or a new `integration_github_test.go`) that, when `INTEGRATION_GITHUB_TOKEN` and `INTEGRATION_GITHUB_REPO` env vars are set, exercises the full review-bot flow against a real GitHub PR using `VCS_TYPE=github`. - The test must skip gracefully when the env vars are absent. - The test must verify that `PostReview` succeeds and that the correct adapter is selected. ## References - [PR #131](https://gitea.weiker.me/rodin/review-bot/pulls/131) - [Issue #130](https://gitea.weiker.me/rodin/review-bot/issues/130)
rodin added the ai-reviewbug labels 2026-05-14 22:16:03 +00:00
rodin closed this issue 2026-05-14 22:53:44 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai-review
bug
needs-review
ready
Ready for human review
 self-reviewed
Self-review passed since last push
 wip
Work in progress - do not start new work on this PR
No Label ai-review bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
security-review-bot rodin (Rodin)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: rodin/review-bot#133
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?