rodin/review-bot
2
1
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases 6 Wiki Activity

Rename GITEA_URL env var to generic VCS_URL for multi-host support #125

New Issue
Closed
opened 2026-05-14 05:05:15 +00:00 by rodin · 0 comments
rodin commented 2026-05-14 05:05:15 +00:00
Owner
Copy Link
Copy Source

Context

The action's Run review step passes GITEA_URL as an environment variable to the review-bot binary. Now that the action supports both Gitea and GitHub/GHES, the name is misleading.

Problem

GITEA_URL suggests the binary only works with Gitea, but it's actually the generic VCS server URL used for both platforms.

Proposed Fix

  1. Rename the env var in the Go binary from GITEA_URL to VCS_URL (or SERVER_URL)
  2. Support GITEA_URL as a deprecated fallback for backwards compatibility
  3. Update the action to pass the new env var name

Origin

Identified during PR #121 review (sonnet NIT #4, comment 21207).

## Context The action's `Run review` step passes `GITEA_URL` as an environment variable to the `review-bot` binary. Now that the action supports both Gitea and GitHub/GHES, the name is misleading. ## Problem `GITEA_URL` suggests the binary only works with Gitea, but it's actually the generic VCS server URL used for both platforms. ## Proposed Fix 1. Rename the env var in the Go binary from `GITEA_URL` to `VCS_URL` (or `SERVER_URL`) 2. Support `GITEA_URL` as a deprecated fallback for backwards compatibility 3. Update the action to pass the new env var name ## Origin Identified during PR #121 review (sonnet NIT #4, comment 21207).
rodin closed this issue 2026-05-14 07:08:16 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai-review
bug
needs-review
ready
Ready for human review
 self-reviewed
Self-review passed since last push
 wip
Work in progress - do not start new work on this PR
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
security-review-bot rodin (Rodin)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: rodin/review-bot#125
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?