rodin/review-bot
2
1
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases 6 Wiki Activity

Support multi-arch binary downloads in composite action #124

New Issue
Closed
opened 2026-05-14 04:54:22 +00:00 by rodin · 0 comments
rodin commented 2026-05-14 04:54:22 +00:00
Owner
Copy Link
Copy Source

Problem

The composite action currently hard-codes review-bot-linux-amd64 as the binary name. If arm64 runners or other OS/arch combinations are used, the action will fail to find the correct binary.

Proposed Solution

Derive the asset name dynamically from uname -m / uname -s or accept an input parameter for the target architecture.

Context

Raised in review #3658 comment 21186 during PR #121 review. Deferred as out of scope for that PR (focused on VCS host detection and security hardening).

## Problem The composite action currently hard-codes `review-bot-linux-amd64` as the binary name. If arm64 runners or other OS/arch combinations are used, the action will fail to find the correct binary. ## Proposed Solution Derive the asset name dynamically from `uname -m` / `uname -s` or accept an input parameter for the target architecture. ## Context Raised in review [#3658 comment 21186](https://gitea.weiker.me/rodin/review-bot/pulls/121#issuecomment-21186) during PR #121 review. Deferred as out of scope for that PR (focused on VCS host detection and security hardening).
rodin closed this issue 2026-05-14 06:00:28 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai-review
bug
needs-review
ready
Ready for human review
 self-reviewed
Self-review passed since last push
 wip
Work in progress - do not start new work on this PR
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
security-review-bot rodin (Rodin)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: rodin/review-bot#124
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?