rodin/review-bot
2
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 6 Wiki Activity

Use bytes.NewReader instead of strings.NewReader in PostReview #11

New Issue
Closed
opened 2026-05-01 19:23:38 +00:00 by rodin · 0 comments
rodin commented 2026-05-01 19:23:38 +00:00
Owner
Copy Link
Copy Source

Problem

PostReview does strings.NewReader(string(data)) which copies []byte → string → io.Reader. Extra allocation.

Fix

Use bytes.NewReader(data) directly. Small optimization but correct.

## Problem `PostReview` does `strings.NewReader(string(data))` which copies `[]byte` → `string` → `io.Reader`. Extra allocation. ## Fix Use `bytes.NewReader(data)` directly. Small optimization but correct.
rodin closed this issue 2026-05-01 21:16:26 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ai-review
bug
needs-review
ready
Ready for human review
 self-reviewed
Self-review passed since last push
 wip
Work in progress - do not start new work on this PR
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
security-review-bot rodin (Rodin)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: rodin/review-bot#11
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?