nit: clarify truncation detection comment in ListReviews

Expand the inline comment at the page==maxPages check to more explicitly explain why a full final page implies truncation.
style: fix import ordering and restore nil-body comment
2026-05-13 18:01:57 -07:00 · 2026-05-13 17:53:20 -07:00
2 changed files with 6 additions and 3 deletions
@@ -2,9 +2,9 @@ package github

 import (
 	"context"
-	"fmt"
 	"encoding/json"
 	"errors"
+	"fmt"
 	"io"
 	"net/http"
 	"strings"
@@ -197,8 +197,10 @@ func (c *Client) ListReviews(ctx context.Context, owner, repo string, number int
 			break
 		}

-		// If we just fetched page maxPages and it was full (the short-page break
-		// above didn't fire), more reviews likely exist beyond our limit.
+		// Truncation detection: this runs on the final allowed iteration
+		// (page == maxPages) only when the page was full (the len < perPage
+		// early-break above didn't fire). A full final page means additional
+		// reviews likely exist beyond our pagination limit.
 		if page == maxPages {
 			truncated = true
 		}
@@ -221,6 +223,7 @@ func (c *Client) DeleteReview(ctx context.Context, owner, repo string, number in
 	reqURL := fmt.Sprintf("%s/repos/%s/%s/pulls/%d/reviews/%d",
 		c.baseURL, url.PathEscape(owner), url.PathEscape(repo), number, reviewID)

+	// nil body: the GitHub DELETE endpoint for reviews requires no request body.
 	_, err := c.doRequestWithBody(ctx, http.MethodDelete, reqURL, nil)
 	if err != nil {
 		var apiErr *APIError
Author	SHA1	Message	Date
claw	437e318240	nit: clarify truncation detection comment in ListReviews PR Ready Gate / clear-labels (pull_request) Successful in 2s Details CI / test (pull_request) Successful in 19s Details CI / review (gpt-5, security, ., rodin/security-patterns, SECURITY_REVIEW.md, SECURITY_REVIEW_TOKEN) (pull_request) Successful in 39s Details CI / review (anthropic--claude-4.6-sonnet, sonnet, SONNET_REVIEW_TOKEN) (pull_request) Successful in 39s Details CI / review (gpt-5, gpt, GPT_REVIEW_TOKEN) (pull_request) Successful in 59s Details Expand the inline comment at the page==maxPages check to more explicitly explain why a full final page implies truncation.	2026-05-13 18:01:57 -07:00
claw	2e2fcbabfc	style: fix import ordering and restore nil-body comment PR Ready Gate / clear-labels (pull_request) Successful in 2s Details CI / test (pull_request) Successful in 19s Details CI / review (gpt-5, security, ., rodin/security-patterns, SECURITY_REVIEW.md, SECURITY_REVIEW_TOKEN) (pull_request) Successful in 38s Details CI / review (anthropic--claude-4.6-sonnet, sonnet, SONNET_REVIEW_TOKEN) (pull_request) Successful in 40s Details CI / review (gpt-5, gpt, GPT_REVIEW_TOKEN) (pull_request) Successful in 56s Details - Reorder stdlib imports in review_test.go to alphabetical (goimports convention) - Restore explanatory comment for nil body in DeleteReview Addresses review comments #20533, #20534 on PR #119	2026-05-13 17:53:20 -07:00