Compare commits

..

1 Commits

Author SHA1 Message Date
claw d75e737f07 test(#139): improve cmd/review-bot coverage from 44.6% to 49.3%
CI / test (pull_request) Successful in 17s
CI / review (anthropic--claude-4.6-sonnet, sonnet, SONNET_REVIEW_TOKEN) (pull_request) Successful in 27s
CI / review (gpt-5, security, ., rodin/security-patterns, SECURITY_REVIEW.md, SECURITY_REVIEW_TOKEN) (pull_request) Successful in 34s
CI / review (gpt-5, gpt, GPT_REVIEW_TOKEN) (pull_request) Successful in 50s
Add tests for previously uncovered paths:

- TestIsValidateError_Nil: isValidateError(nil, ...) returns false
- TestValidateURL_EmptyHost: URL with no hostname (https://) → code-2 error
- TestRunValidateURL_Success: success path (OK output + exit 0) via example.com
- TestMainSubprocess_MissingLLMBaseURL: --llm-base-url required for openai provider
- TestMainSubprocess_MissingAICoreCredentials: aicore creds required for provider=aicore
- TestMainSubprocess_ConflictingPersonaFlags: --persona and --persona-file are mutually exclusive
- TestMainSubprocess_DeprecatedGiteaURLEnv: GITEA_URL env var emits deprecation warning

All tests pass; no production code changes; dep check clean.
2026-05-14 21:15:12 -07:00
2 changed files with 30 additions and 28 deletions
+25 -18
View File
@@ -1,36 +1,43 @@
============================================================================= =============================================================================
REVIEW-BOT DEV LOOP STATUS — 2026-05-15 04:08 UTC REVIEW-BOT DEV LOOP STATUS — 2026-05-15 01:48 UTC (post-sync)
============================================================================= =============================================================================
OVERALL STATUS: ✅ PR OPEN OVERALL STATUS: ✅ OPTIMAL
Active Work: Test Results (fresh run post-sync):
- PR #140: test(#139): improve cmd/review-bot coverage 44.6% → 49.3%
State: open, labeled: ready, self-reviewed
Branch: issue-139
Test Results (last full run, worktree):
- All 6 packages: PASS ✅ - All 6 packages: PASS ✅
- Build: ✅ clean - Build: ✅ clean
- Vet: ✅ clean - Vet: ✅ clean
- Fresh run: -count=1 verified
Coverage (post-change): Recent Major Changes (synced from origin/main):
- cmd/review-bot: 49.3% (was 44.6%) - Significant new GitHub client methods (~360 lines added)
- review: 91.9% - New validateurl package for URL validation
- budget: 92.0% - New vcs adapter layer for VCS abstraction
- New gitea/ipcheck package for IP validation
- Expanded integration tests in cmd/review-bot
- All changes verified passing tests
Coverage (current post-sync):
- review: 92.0%
- budget: 91.8%
- github: 86.3% - github: 86.3%
- gitea: 85.2% - gitea: 85.2%
- llm: 81.3% - llm: 81.3%
- cmd/review-bot: 46.1%
Repository (main): Repository:
- Branch: main (up to date with origin — 1e3d86b) - Branch: main (synced with origin — 4ffa6b6)
- Working tree: clean - Working tree: clean
- Open issues: 1 (#139, addressed by PR #140) - Open issues: 0
- Open PRs: 1 (#140, ready for review) - Open PRs: 0
System Health: ✅ GREEN System Health: ✅ GREEN
✓ All tests passing ✓ All tests passing (33 commits synced)
✓ No warnings ✓ No warnings
PR ready for merge Code clean
✓ Ready for feature work
Next Cycle: Ready to pick up feature work
============================================================================= =============================================================================
+5 -10
View File
@@ -1,4 +1,4 @@
## Dev Loop Status: 2026-05-15 04:35 UTC ## Dev Loop Status: 2026-05-15 02:28 UTC
**Repository:** review-bot (rodin/review-bot on Gitea) **Repository:** review-bot (rodin/review-bot on Gitea)
**Status:** ✅ OPTIMAL **Status:** ✅ OPTIMAL
@@ -15,28 +15,23 @@
### Recent Changes ### Recent Changes
- ✅ Merged PR #140: test coverage improvements (44.6% → 49.3%) Last commit: `dcfd360` (2026-05-15 01:48) — health check post-sync
- ✅ PR #137 (doc-map feature) merged successfully with all reviews approved
### Coverage ### Coverage
| Package | Coverage | | Package | Coverage |
|---------|----------| |---------|----------|
| cmd/review-bot | 49.3% ↑ | | cmd/review-bot | 46.1% |
| gitea | 85.2% | | gitea | 85.2% |
| github | 86.3% | | github | 86.3% |
| review | 92.0% | | review | 92.0% |
### Status Summary
All recent feature work (doc-map, coverage improvements) successfully integrated. Repository is stable and ready for next development cycle.
### Next Priority ### Next Priority
- Continue increasing cmd/review-bot coverage (target: ≥60%) - Increase cmd/review-bot coverage (lowest at 46.1%)
- Monitor prod logs for edge cases - Monitor prod logs for edge cases
- VCS integration stable; GitHub + Gitea paths clear - VCS integration stable; GitHub + Gitea paths clear
--- ---
_Dev-loop cycle complete at 04:35 UTC._ _Dev-loop cycle complete at 02:28 UTC._