5252143a33
fix: address review feedback — alias default, acronym convention, observability
...
PR Ready Gate / clear-labels (pull_request) Successful in 2s
CI / test (pull_request) Successful in 19s
CI / review (gpt-5, gpt, GPT_REVIEW_TOKEN) (pull_request) Failing after 6s
CI / review (anthropic--claude-4.6-sonnet, sonnet, SONNET_REVIEW_TOKEN) (pull_request) Failing after 10s
CI / review (gpt-5, security, ., rodin/security-patterns, SECURITY_REVIEW.md, SECURITY_REVIEW_TOKEN) (pull_request) Failing after 10s
- #19639 : Use empty default for --gitea-url alias to remove ordering dependency
- #19640 : Upgrade slog.Warn to slog.Error for missing ReviewSuperseder (signals bug)
- #19641 : Remove orphaned comment fragment from buildSupersededBody relocation
- #19642 : Rename ProviderGithub → ProviderGitHub per Go acronym convention
- #19643 : Log resolution failures at debug level in SupersedeReviews
2026-05-13 09:20:33 -07:00
ac6d34f5bd
fix: address review feedback - eliminate type assertion via ReviewSuperseder interface
...
PR Ready Gate / clear-labels (pull_request) Successful in 2s
CI / test (pull_request) Successful in 19s
CI / review (anthropic--claude-4.6-sonnet, sonnet, SONNET_REVIEW_TOKEN) (pull_request) Successful in 56s
CI / review (gpt-5, security, ., rodin/security-patterns, SECURITY_REVIEW.md, SECURITY_REVIEW_TOKEN) (pull_request) Successful in 1m51s
CI / review (gpt-5, gpt, GPT_REVIEW_TOKEN) (pull_request) Successful in 2m21s
- Introduce vcs.VCSProvider typed constant (replaces plain string provider)
- Introduce vcs.ReviewSuperseder optional interface for supersede logic
- Implement SupersedeReviews on gitea.Adapter (edit + resolve) and
github.Client (dismiss)
- Remove concrete type assertion client.(*gitea.Adapter) from main
- Remove redundant baseURL fallback for github (NewClient defaults it)
- Condense --gitea-url alias comment block
- Fix fetchPatterns comment (empty paths are skipped, not fetched)
- Add default panic to VCS client init switch
Addresses: #19607 , #19608 , #19609 , #19610 , #19621 , #19622 , #19623
2026-05-13 09:03:42 -07:00
claw