4 Commits

Include renames

Author	SHA1	Message	Date
claw	9f8e9aa8d3	fix: timer leak and http field shadowing in github client ... - Add timer.Stop() to the timer.C branch to prevent timer leak on the normal path (previously only called in ctx.Done branch) - Rename struct field 'http' to 'httpClient' to avoid shadowing the net/http import Addresses self-review findings on PR #110.	2026-05-13 06:22:30 -07:00
claw	31a28b1dd5	address review feedback: baseURL TODO, timer-cancel test, fast retry test, doc note ... - Add TODO comment on unused baseURL field explaining its intended future use by higher-level exported methods - Rewrite TestDoRequest_ContextCanceled to actually exercise the timer-cancel path in the retry select (goroutine cancels context while client is blocked in timer.C select) - Change Retry-After: 1 to Retry-After: 0 in IntegerSeconds test to avoid unnecessary 1s sleep during test runs - Add doc note on SetRetryBackoff explaining that an empty non-nil slice silently drops Retry-After delays	2026-05-13 06:08:51 -07:00
claw	e414471a16	fix(github): address review feedback on Retry-After implementation ... - Fix data race: copy retryBackoff slice per-request to prevent concurrent doRequest calls from racing on shared state - Fix parseRetryAfter: trim whitespace before parsing for robustness - Fix parseRetryAfter: treat delta-seconds of 0 as valid per RFC 7231 - Add bounded read on success path (10 MB limit) for defense-in-depth - Clean up TestDoRequest_429_RetryAfter_IntegerSeconds: remove dead code block and commented-out reasoning - Fix import ordering: context before errors (goimports compliance)	2026-05-13 05:54:06 -07:00
claw	41e1d48b54	feat(github): support HTTP-date format in Retry-After header ... Implement the github package client with Retry-After header parsing that supports both integer seconds (e.g. "Retry-After: 120") and HTTP-date format (e.g. "Retry-After: Thu, 01 Dec 2025 16:00:00 GMT") per RFC 7231 §7.1.3. Key design decisions: - Use http.ParseTime which handles RFC 1123, RFC 850, and ASCTIME formats - Cap maximum retry delay at 60s (maxRetryAfter) to prevent stalling - If HTTP-date is in the past, use delay of 0 (retry immediately) - Inject time.Now via c.now field for deterministic testing Closes #94	2026-05-13 05:10:52 -07:00