rodin/review-bot
2
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 6 Wiki Activity

fix: remove anthropic_version from body - AI Core rejects it
CI / test (pull_request) Successful in 15s
Details
CI / review (anthropic--claude-4.6-sonnet, sonnet, SONNET_REVIEW_TOKEN) (pull_request) Failing after 17s
Details
CI / review (gpt-5, security, SECURITY_REVIEW.md, SECURITY_REVIEW_TOKEN) (pull_request) Successful in 1m37s
Details
CI / review (gpt-5, gpt, GPT_REVIEW_TOKEN) (pull_request) Successful in 2m2s
Details

Browse Source
This commit is contained in:
Rodin
2026-05-09 23:45:11 -07:00
parent 8da8fca19d
commit f71f26fcff
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
llm/aicore.go
+1 -1
View File
@@ -253,7 +253,7 @@ func (c *AICoreClient) CompleteAnthropic(ctx context.Context, model string, mess
} }
reqBody := anthropicRequest{ reqBody := anthropicRequest{
AnthropicVersion: "2023-06-01", // AnthropicVersion omitted - SAP AI Core does not accept it in body
// Model omitted - AI Core deployment already specifies model // Model omitted - AI Core deployment already specifies model
MaxTokens: maxTokens, MaxTokens: maxTokens,
System: system, System: system,
llm/aicore_test.go
+2 -2
View File
@@ -206,8 +206,8 @@ func TestAICoreClient_CompleteAnthropic(t *testing.T) {
if err := json.NewDecoder(r.Body).Decode(&req); err != nil { if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
t.Fatalf("decode request: %v", err) t.Fatalf("decode request: %v", err)
} }
if req.AnthropicVersion != "2023-06-01" { if req.MaxTokens == 0 {
t.Errorf("expected anthropic_version in request") t.Errorf("expected max_tokens in request")
} }
if req.System != "You are helpful" { if req.System != "You are helpful" {
t.Errorf("expected system prompt: %q", req.System) t.Errorf("expected system prompt: %q", req.System)