fix: address review findings (pagination, case-insensitive bool, docs)
CI / test (pull_request) Successful in 14s
CI / review (gpt-4.1, gpt, GPT_REVIEW_TOKEN) (pull_request) Successful in 22s
CI / review (gpt-5, sonnet, SONNET_REVIEW_TOKEN) (pull_request) Successful in 59s

- ListReviews: add ?limit=50 to handle PRs with many reviews
- envOrDefaultBool: case-insensitive, whitespace-trimmed (TRUE/Yes/1 all work)
- action.yml: document accepted boolean values in description
- Test: verify limit query parameter is sent
This commit is contained in:
Rodin
2026-05-01 20:22:03 -07:00
parent 0d417e068e
commit dd2426f80a
4 changed files with 6 additions and 3 deletions
+3
View File
@@ -361,6 +361,9 @@ func TestListReviews(t *testing.T) {
if r.URL.Path != "/api/v1/repos/owner/repo/pulls/5/reviews" {
t.Errorf("unexpected path: %s", r.URL.Path)
}
if r.URL.Query().Get("limit") != "50" {
t.Errorf("expected limit=50, got %s", r.URL.Query().Get("limit"))
}
w.Header().Set("Content-Type", "application/json")
w.Write([]byte(`[{"id":10,"user":{"login":"bot-a"},"state":"APPROVED","stale":false},{"id":11,"user":{"login":"bot-b"},"state":"REQUEST_CHANGES","stale":true}]`))
}))