feat: replace log.Printf with structured slog logging
CI / test (pull_request) Successful in 14s
CI / review (gpt-4.1, gpt, GPT_REVIEW_TOKEN) (pull_request) Successful in 23s
CI / review (gpt-5, security, SECURITY_REVIEW.md, SECURITY_REVIEW_TOKEN) (pull_request) Successful in 52s
CI / review (gpt-5, sonnet, SONNET_REVIEW_TOKEN) (pull_request) Successful in 1m5s
CI / test (pull_request) Successful in 14s
CI / review (gpt-4.1, gpt, GPT_REVIEW_TOKEN) (pull_request) Successful in 23s
CI / review (gpt-5, security, SECURITY_REVIEW.md, SECURITY_REVIEW_TOKEN) (pull_request) Successful in 52s
CI / review (gpt-5, sonnet, SONNET_REVIEW_TOKEN) (pull_request) Successful in 1m5s
- Add --log-format flag (text/json) and --verbosity flag (debug/info/warn/error) - Replace all log.Printf with slog.Info/Debug/Warn with structured key-value attrs - Replace all log.Fatalf with slog.Error + os.Exit(1) - Convert gitea/client.go warnings to slog.Warn - Add comprehensive tests for logger initialization and level filtering Closes #23 Partially addresses #32
This commit is contained in:
@@ -1,6 +1,9 @@
|
||||
package main
|
||||
|
||||
import (
|
||||
"bytes"
|
||||
"log/slog"
|
||||
"strings"
|
||||
"testing"
|
||||
|
||||
"gitea.weiker.me/rodin/review-bot/gitea"
|
||||
@@ -268,3 +271,97 @@ func TestExtractSentinelName(t *testing.T) {
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func TestSetupLogger_JSONFormat(t *testing.T) {
|
||||
// Capture output by creating a logger manually with the same logic
|
||||
var buf bytes.Buffer
|
||||
opts := &slog.HandlerOptions{Level: slog.LevelInfo}
|
||||
handler := slog.NewJSONHandler(&buf, opts)
|
||||
logger := slog.New(handler)
|
||||
|
||||
logger.Info("test message", "key", "value")
|
||||
|
||||
output := buf.String()
|
||||
if !strings.Contains(output, `"msg":"test message"`) {
|
||||
t.Errorf("expected JSON msg field, got: %s", output)
|
||||
}
|
||||
if !strings.Contains(output, `"key":"value"`) {
|
||||
t.Errorf("expected JSON key field, got: %s", output)
|
||||
}
|
||||
if !strings.Contains(output, `"level":"INFO"`) {
|
||||
t.Errorf("expected JSON level field, got: %s", output)
|
||||
}
|
||||
}
|
||||
|
||||
func TestSetupLogger_TextFormat(t *testing.T) {
|
||||
var buf bytes.Buffer
|
||||
opts := &slog.HandlerOptions{Level: slog.LevelInfo}
|
||||
handler := slog.NewTextHandler(&buf, opts)
|
||||
logger := slog.New(handler)
|
||||
|
||||
logger.Info("test message", "key", "value")
|
||||
|
||||
output := buf.String()
|
||||
if !strings.Contains(output, "msg=\"test message\"") && !strings.Contains(output, "msg=test") {
|
||||
t.Errorf("expected text msg field, got: %s", output)
|
||||
}
|
||||
if !strings.Contains(output, "key=value") {
|
||||
t.Errorf("expected text key field, got: %s", output)
|
||||
}
|
||||
}
|
||||
|
||||
func TestSetupLogger_LevelFiltering(t *testing.T) {
|
||||
tests := []struct {
|
||||
name string
|
||||
verbosity string
|
||||
logLevel slog.Level
|
||||
expected bool // should the message appear
|
||||
}{
|
||||
{"info logger shows info", "info", slog.LevelInfo, true},
|
||||
{"info logger hides debug", "info", slog.LevelDebug, false},
|
||||
{"debug logger shows debug", "debug", slog.LevelDebug, true},
|
||||
{"warn logger hides info", "warn", slog.LevelInfo, false},
|
||||
{"warn logger shows warn", "warn", slog.LevelWarn, true},
|
||||
{"error logger hides warn", "error", slog.LevelWarn, false},
|
||||
{"error logger shows error", "error", slog.LevelError, true},
|
||||
}
|
||||
|
||||
for _, tc := range tests {
|
||||
t.Run(tc.name, func(t *testing.T) {
|
||||
var level slog.Level
|
||||
switch tc.verbosity {
|
||||
case "debug":
|
||||
level = slog.LevelDebug
|
||||
case "info":
|
||||
level = slog.LevelInfo
|
||||
case "warn":
|
||||
level = slog.LevelWarn
|
||||
case "error":
|
||||
level = slog.LevelError
|
||||
}
|
||||
|
||||
var buf bytes.Buffer
|
||||
opts := &slog.HandlerOptions{Level: level}
|
||||
handler := slog.NewTextHandler(&buf, opts)
|
||||
logger := slog.New(handler)
|
||||
|
||||
logger.Log(nil, tc.logLevel, "test")
|
||||
|
||||
hasOutput := buf.Len() > 0
|
||||
if hasOutput != tc.expected {
|
||||
t.Errorf("verbosity=%s, logLevel=%s: got output=%v, want %v",
|
||||
tc.verbosity, tc.logLevel, hasOutput, tc.expected)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestSetupLogger_Integration(t *testing.T) {
|
||||
// Test that setupLogger doesn't panic for valid inputs
|
||||
setupLogger("text", "info")
|
||||
setupLogger("json", "debug")
|
||||
setupLogger("text", "warn")
|
||||
setupLogger("json", "error")
|
||||
setupLogger("text", "unknown") // should default to info
|
||||
setupLogger("invalid", "info") // should default to text
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user