rodin/review-bot
2
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 6 Wiki Activity

[dev-loop] Update TODO.md with current cycle status and coverage metrics
CI / test (push) Successful in 18s
Details
CI / review (anthropic--claude-4.6-sonnet, sonnet, SONNET_REVIEW_TOKEN) (push) Has been skipped
Details
CI / review (gpt-5, gpt, GPT_REVIEW_TOKEN) (push) Has been skipped
Details
CI / review (gpt-5, security, ., rodin/security-patterns, SECURITY_REVIEW.md, SECURITY_REVIEW_TOKEN) (push) Has been skipped
Details

Browse Source
This commit is contained in:
Rodin
2026-05-14 23:12:43 +00:00
parent 6f02cef662
commit b534247c85
1 changed files with 27 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files
TODO.md
+27 -27
View File
@@ -1,9 +1,9 @@
## Dev Loop: review-bot — Continuous Health Monitor ## Dev Loop: review-bot — Continuous Health Monitor
### Current Cycle: 2026-05-15 02:10 UTC ✅ ### Current Cycle: 2026-05-14 23:11 UTC ✅
**Repository Status:** OPTIMAL **Repository Status:** OPTIMAL
- Main: `9f3f321` (clean, all tests pass) - Main: `6f02cef` (clean, all tests pass)
- Working tree: clean - Working tree: clean
- Build: ✅ successful - Build: ✅ successful
- Vet: ✅ clean - Vet: ✅ clean
@@ -11,34 +11,28 @@
--- ---
## Latest Delivered: Issue #130 ✅ ## Latest Delivered: Test Coverage Sprint 2026-05-14 ✅
### GitHub API + VCS Routing Complete ### Coverage Improvements
**Phase 1: GitHub API Methods** ✅ 22 new tests added across 4 packages:
- 12+ methods implemented in `github/client.go`
- GetPullRequest, GetPullRequestDiff, GetPullRequestFiles
- GetCommitStatuses, GetFileContent, ListContents, GetAllFilesInPath
- PostReview, ListReviews, DeleteReview, GetAuthenticatedUser, RequestReviewer
**Phase 2: VCS Abstraction** ✅ | Package | Before | After | Delta |
- `vcsClient` interface (GitHub + Gitea) |---------|--------|-------|-------|
- `giteaExtClient` interface (Gitea-specific ops) | cmd/review-bot | 37.6% | 46.1% | +8.5% |
- Adapters for both platforms | gitea | 80.0% | 85.2% | +5.2% |
- URL-based auto-detection (github.com → GitHub, else Gitea) | github | 79.9% | 86.3% | +6.4% |
- `--vcs-type` flag and `VCS_TYPE` env override | review | 91.5% | 92.0% | +0.5% |
**Quality Metrics** ✅ **What was tested:**
- 474 lines of GitHub client tests - `fetchFileContext`: empty, removed files, content fetching, error recovery, context cancellation
- 82 lines of routing tests - `fetchPatterns`: empty repo, all files, specific files, invalid format, errors, multiple repos
- 361 lines of VCS adapter code - `LoadPersona`: nonexistent file, non-regular file (directory), oversized file
- Security review: APPROVED (MINOR: URL heuristic note) - `CapitalizeFirst`: RuneError (invalid UTF-8)
- All tests passing; go vet clean - `GetTimelineReviewCommentIDForReview` (gitea): 4 cases including user+body matching
- `GetAllFilesInPath` (github): directory listing, 404 fallback, recursive subdirectory
**Known Limitations** (Documented) **Commits:** `fccfdd2`, `6f02cef`
- GitHub: Can only delete PENDING (draft) reviews, not submitted (handled gracefully)
- GitHub pagination: per-page=100 with Link header checking
- Check-runs: Uses statuses API; check-runs deferrable to future enhancement
--- ---
@@ -57,6 +51,12 @@
| #127 | #124 | Multi-arch binary support | ✅ MERGED | | #127 | #124 | Multi-arch binary support | ✅ MERGED |
| #126 | #120 | GitHub Actions composite action | ✅ MERGED | | #126 | #120 | GitHub Actions composite action | ✅ MERGED |
### Recent Direct Commits
| SHA | Description | Date |
|-----|-------------|------|
| `fccfdd2` | [dev-loop] fetchFileContext/fetchPatterns/persona tests | 2026-05-14 |
| `6f02cef` | [dev-loop] GetTimelineReviewCommentIDForReview/GetAllFilesInPath tests | 2026-05-14 |
### Closed Issues ### Closed Issues
- #130, #123, #125, #124, #120 - #130, #123, #125, #124, #120
@@ -141,8 +141,8 @@
| Key | Value | | Key | Value |
|---|---| |---|---|
| Repo | `/home/ubuntu/review-bot` | | Repo | `/home/ubuntu/review-bot` |
| Main SHA | `9f3f321` | | Main SHA | `6f02cef` |
| Last update | 2026-05-15 02:10 UTC | | Last update | 2026-05-14 23:11 UTC |
| Status | All systems optimal | | Status | All systems optimal |
| Next phase | PR submission or GitHub Enterprise support | | Next phase | PR submission or GitHub Enterprise support |