fix: address review findings (pagination, case-insensitive bool, docs)
CI / test (pull_request) Successful in 13s
CI / review (gpt-4.1, gpt, GPT_REVIEW_TOKEN) (pull_request) Successful in 21s
CI / review (gpt-5, sonnet, SONNET_REVIEW_TOKEN) (pull_request) Successful in 1m0s

- PostReview now returns *Review (id + user login from response)
- Delete flow reversed: post first, then clean up stale reviews
- No longer requires read:user scope (was causing 403 in CI)
- Identity determined from POST response, not GET /api/v1/user
- ListReviews: full pagination (loops until partial page)
- envOrDefaultBool: case-insensitive, whitespace-trimmed
- action.yml: document accepted boolean values
- Tests updated for new PostReview signature
This commit is contained in:
Rodin
2026-05-01 20:22:03 -07:00
parent 0d417e068e
commit a73b3867a5
4 changed files with 113 additions and 48 deletions
+1 -1
View File
@@ -67,7 +67,7 @@ inputs:
required: false
default: 'false'
update-existing:
description: 'Delete previous review from same bot before posting (default true)'
description: 'Delete previous review from same bot before posting. Accepts: true/1/yes or false/0/no (default true)'
required: false
default: 'true'