fix: address review NITs — readability, test dedup, consistent SHA var
PR Ready Gate / clear-labels (pull_request) Successful in 2s
CI / test (pull_request) Successful in 30s
CI / review (anthropic--claude-4.6-sonnet, sonnet, SONNET_REVIEW_TOKEN) (pull_request) Successful in 22s
CI / review (gpt-5, security, ., rodin/security-patterns, SECURITY_REVIEW.md, SECURITY_REVIEW_TOKEN) (pull_request) Successful in 34s
CI / review (gpt-5, gpt, GPT_REVIEW_TOKEN) (pull_request) Successful in 1m6s
PR Ready Gate / clear-labels (pull_request) Successful in 2s
CI / test (pull_request) Successful in 30s
CI / review (anthropic--claude-4.6-sonnet, sonnet, SONNET_REVIEW_TOKEN) (pull_request) Successful in 22s
CI / review (gpt-5, security, ., rodin/security-patterns, SECURITY_REVIEW.md, SECURITY_REVIEW_TOKEN) (pull_request) Successful in 34s
CI / review (gpt-5, gpt, GPT_REVIEW_TOKEN) (pull_request) Successful in 1m6s
- vcs/types.go: restore blank line between CommitID and Comments fields for visual grouping (scalar vs slice fields) - gitea/adapter_test.go: merge duplicate TestAdapter_PostReview_CommitID tests into one (Threading was a superset) - cmd/review-bot/main.go: use evaluatedSHA instead of pr.Head.SHA for inline comment CommitID for consistency with review-level usage
This commit is contained in:
@@ -439,7 +439,7 @@ func main() {
|
|||||||
inlineComments = append(inlineComments, vcs.ReviewComment{
|
inlineComments = append(inlineComments, vcs.ReviewComment{
|
||||||
Path: f.File,
|
Path: f.File,
|
||||||
Position: pos,
|
Position: pos,
|
||||||
CommitID: pr.Head.SHA,
|
CommitID: evaluatedSHA,
|
||||||
Body: fmt.Sprintf("**[%s]** %s", f.Severity, f.Finding),
|
Body: fmt.Sprintf("**[%s]** %s", f.Severity, f.Finding),
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
|
|||||||
+1
-35
@@ -214,40 +214,6 @@ func TestAdapter_PostReview_EventTranslation(t *testing.T) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestAdapter_PostReview_CommitID(t *testing.T) {
|
|
||||||
var gotCommitID string
|
|
||||||
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
||||||
w.Header().Set("Content-Type", "application/json")
|
|
||||||
var payload struct {
|
|
||||||
CommitID string `json:"commit_id"`
|
|
||||||
}
|
|
||||||
json.NewDecoder(r.Body).Decode(&payload)
|
|
||||||
gotCommitID = payload.CommitID
|
|
||||||
json.NewEncoder(w).Encode(map[string]any{
|
|
||||||
"id": 1,
|
|
||||||
"body": "test",
|
|
||||||
"user": map[string]any{"login": "bot"},
|
|
||||||
"commit_id": payload.CommitID,
|
|
||||||
})
|
|
||||||
}))
|
|
||||||
defer server.Close()
|
|
||||||
|
|
||||||
client := gitea.NewClient(server.URL, "token")
|
|
||||||
adapter := gitea.NewAdapter(client)
|
|
||||||
|
|
||||||
_, err := adapter.PostReview(context.Background(), "owner", "repo", 1, vcs.ReviewRequest{
|
|
||||||
Body: "test",
|
|
||||||
Event: vcs.ReviewEventApprove,
|
|
||||||
CommitID: "sha256abc",
|
|
||||||
})
|
|
||||||
if err != nil {
|
|
||||||
t.Fatalf("unexpected error: %v", err)
|
|
||||||
}
|
|
||||||
if gotCommitID != "sha256abc" {
|
|
||||||
t.Errorf("expected commit_id %q forwarded to client, got %q", "sha256abc", gotCommitID)
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
func TestAdapter_PostReview_WithComments_PositionTranslation(t *testing.T) {
|
func TestAdapter_PostReview_WithComments_PositionTranslation(t *testing.T) {
|
||||||
diff := `diff --git a/main.go b/main.go
|
diff := `diff --git a/main.go b/main.go
|
||||||
--- a/main.go
|
--- a/main.go
|
||||||
@@ -443,7 +409,7 @@ func TestAdapter_RequestReviewerSelf(t *testing.T) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestAdapter_PostReview_CommitID_Threading(t *testing.T) {
|
func TestAdapter_PostReview_CommitID(t *testing.T) {
|
||||||
var gotPayload struct {
|
var gotPayload struct {
|
||||||
Body string `json:"body"`
|
Body string `json:"body"`
|
||||||
Event string `json:"event"`
|
Event string `json:"event"`
|
||||||
|
|||||||
@@ -98,5 +98,6 @@ type ReviewRequest struct {
|
|||||||
// If empty, the platform defaults to the current PR head.
|
// If empty, the platform defaults to the current PR head.
|
||||||
// Adapters use this as the primary commit anchor for the review submission.
|
// Adapters use this as the primary commit anchor for the review submission.
|
||||||
CommitID string `json:"commit_id,omitempty"`
|
CommitID string `json:"commit_id,omitempty"`
|
||||||
|
|
||||||
Comments []ReviewComment `json:"comments,omitempty"`
|
Comments []ReviewComment `json:"comments,omitempty"`
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user