From 8d53b649ee35ca7553e090cacc71ded3b5297077 Mon Sep 17 00:00:00 2001
From: Rodin <rodin@forgedthought.ai>
Date: Fri, 1 May 2026 11:38:28 -0700
Subject: [PATCH] fix: address review findings (cache path, docs)

- Composite action: cache to runner.temp instead of /usr/local/bin
  (avoids permission issues on runners)
- Document that temperature=0 means server default (omitted from request)
- Note: strconv import already exists (false positive from GPT-5)
---
 .gitea/actions/review/action.yml | 8 ++++----
 llm/client.go                    | 2 ++
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/.gitea/actions/review/action.yml b/.gitea/actions/review/action.yml
index d69428a..61f75f7 100644
--- a/.gitea/actions/review/action.yml
+++ b/.gitea/actions/review/action.yml
@@ -70,7 +70,7 @@ runs:
       id: cache
       uses: actions/cache@v4
       with:
-        path: /usr/local/bin/review-bot
+        path: ${{ runner.temp }}/review-bot
         key: review-bot-linux-amd64-${{ steps.version.outputs.version }}
 
     - name: Install review-bot
@@ -79,8 +79,8 @@ runs:
       run: |
         GITEA_URL="${{ inputs.gitea-url || github.server_url }}"
         VERSION="${{ steps.version.outputs.version }}"
-        curl -sSfL "${GITEA_URL}/rodin/review-bot/releases/download/${VERSION}/review-bot-linux-amd64" -o /usr/local/bin/review-bot
-        chmod +x /usr/local/bin/review-bot
+        curl -sSfL "${GITEA_URL}/rodin/review-bot/releases/download/${VERSION}/review-bot-linux-amd64" -o ${{ runner.temp }}/review-bot
+        chmod +x ${{ runner.temp }}/review-bot
 
     - name: Run review
       shell: bash
@@ -100,4 +100,4 @@ runs:
         if [ "${{ inputs.dry-run }}" = "true" ]; then
           ARGS="--dry-run"
         fi
-        review-bot $ARGS
+        ${{ runner.temp }}/review-bot $ARGS
diff --git a/llm/client.go b/llm/client.go
index a6bbccb..5af281b 100644
--- a/llm/client.go
+++ b/llm/client.go
@@ -29,6 +29,8 @@ func NewClient(baseURL, apiKey, model string) *Client {
 }
 
 // WithTemperature sets the temperature for LLM requests.
+// A value of 0 (the zero value) means the field is omitted from the request,
+// causing the server to use its default temperature.
 // If not set (zero value), the server default is used.
 func (c *Client) WithTemperature(t float64) *Client {
 	c.Temperature = t