From 55391c66d8a76da0fcbebbba62eb30270972c7d7 Mon Sep 17 00:00:00 2001 From: Rodin Date: Fri, 1 May 2026 21:42:49 -0700 Subject: [PATCH] refactor: validate reviewer-name early (fail fast before LLM call) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Moved validateReviewerName check to right after flag parsing. Previously it ran after the LLM request completed — wasting an expensive API call if the name was invalid. Sonnet review finding #1. --- cmd/review-bot/main.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/cmd/review-bot/main.go b/cmd/review-bot/main.go index d071934..f31cae4 100644 --- a/cmd/review-bot/main.go +++ b/cmd/review-bot/main.go @@ -57,6 +57,11 @@ func main() { os.Exit(1) } + // Validate reviewer-name: only safe characters allowed in sentinel + if err := validateReviewerName(*reviewerName); err != nil { + log.Fatalf("%v", err) + } + // Parse repo owner/name parts := strings.SplitN(*repo, "/", 2) if len(parts) != 2 { @@ -234,10 +239,6 @@ func main() { return } - // Validate reviewer-name: only safe characters allowed in sentinel - if err := validateReviewerName(*reviewerName); err != nil { - log.Fatalf("%v", err) - } sentinel := fmt.Sprintf("", *reviewerName) log.Printf("Posting review (event=%s)...", event)