From 50091941e13bcd535adc5e7a61e514e834e755ee Mon Sep 17 00:00:00 2001 From: Rodin Date: Sat, 2 May 2026 11:49:24 -0700 Subject: [PATCH] fix: trim trailing slash from giteaURL when building review link Prevents double-slash in supersede URL if GITEA_URL ends with '/'. Aligns with how gitea.NewClient already normalizes the base URL. --- cmd/review-bot/main.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/review-bot/main.go b/cmd/review-bot/main.go index 9f68b01..d003585 100644 --- a/cmd/review-bot/main.go +++ b/cmd/review-bot/main.go @@ -355,7 +355,7 @@ func main() { // Supersede old review with link to the new one if existingReview != nil && existingCommentID > 0 { - newReviewURL := fmt.Sprintf("%s/%s/%s/pulls/%d#pullrequestreview-%d", *giteaURL, owner, repoName, prNumber, posted.ID) + newReviewURL := fmt.Sprintf("%s/%s/%s/pulls/%d#pullrequestreview-%d", strings.TrimRight(*giteaURL, "/"), owner, repoName, prNumber, posted.ID) supersededBody := buildSupersededBody(existingReview.Body, existingReview.CommitID, newReviewURL, sentinel) if err := giteaClient.EditComment(ctx, owner, repoName, existingCommentID, supersededBody); err != nil { slog.Warn("could not mark old review as superseded", "comment_id", existingCommentID, "error", err)