ci: correct triggers and add self-review gate with TTL; gate review job
CI / review-gate (pull_request) Successful in 2s
PR Ready Gate / clear-labels (pull_request) Successful in 2s
CI / test (pull_request) Successful in 17s
CI / review (anthropic--claude-4.6-sonnet, sonnet, SONNET_REVIEW_TOKEN) (pull_request) Has been skipped
CI / review (gpt-5, gpt, GPT_REVIEW_TOKEN) (pull_request) Has been skipped
CI / review (gpt-5, security, ., rodin/security-patterns, SECURITY_REVIEW.md, SECURITY_REVIEW_TOKEN) (pull_request) Has been skipped
CI / review-gate (pull_request) Successful in 2s
PR Ready Gate / clear-labels (pull_request) Successful in 2s
CI / test (pull_request) Successful in 17s
CI / review (anthropic--claude-4.6-sonnet, sonnet, SONNET_REVIEW_TOKEN) (pull_request) Has been skipped
CI / review (gpt-5, gpt, GPT_REVIEW_TOKEN) (pull_request) Has been skipped
CI / review (gpt-5, security, ., rodin/security-patterns, SECURITY_REVIEW.md, SECURITY_REVIEW_TOKEN) (pull_request) Has been skipped
This commit is contained in:
Rodin
+91
-103
@@ -1,71 +1,26 @@
|
|||||||
name: CI
|
name: CI
|
||||||
true:
|
|
||||||
|
on:
|
||||||
push:
|
push:
|
||||||
branches:
|
branches: [main]
|
||||||
- main
|
|
||||||
pull_request:
|
pull_request:
|
||||||
types:
|
types: [opened, synchronize]
|
||||||
- opened
|
|
||||||
- synchronize
|
env:
|
||||||
|
SELF_REVIEW_TTL_MIN: '45'
|
||||||
|
|
||||||
jobs:
|
jobs:
|
||||||
test:
|
test:
|
||||||
runs-on: ubuntu-24.04
|
runs-on: ubuntu-24.04
|
||||||
steps:
|
steps:
|
||||||
- uses: actions/checkout@v4
|
- uses: actions/checkout@v4
|
||||||
- uses: actions/setup-go@v5
|
- uses: actions/setup-go@v5
|
||||||
with:
|
with:
|
||||||
go-version: '1.26'
|
go-version: '1.26'
|
||||||
- run: go test ./...
|
- run: go test ./...
|
||||||
- run: go vet ./...
|
- run: go vet ./...
|
||||||
- run: go build -o review-bot ./cmd/review-bot
|
- run: go build -o review-bot ./cmd/review-bot
|
||||||
review:
|
|
||||||
runs-on: ubuntu-24.04
|
|
||||||
if: github.event_name == 'pull_request' && needs.review-gate.outputs.allow_review
|
|
||||||
== 'true'
|
|
||||||
needs:
|
|
||||||
- test
|
|
||||||
- review-gate
|
|
||||||
strategy:
|
|
||||||
matrix:
|
|
||||||
include:
|
|
||||||
- name: sonnet
|
|
||||||
token_secret: SONNET_REVIEW_TOKEN
|
|
||||||
model: anthropic--claude-4.6-sonnet
|
|
||||||
- name: gpt
|
|
||||||
token_secret: GPT_REVIEW_TOKEN
|
|
||||||
model: gpt-5
|
|
||||||
- name: security
|
|
||||||
token_secret: SECURITY_REVIEW_TOKEN
|
|
||||||
model: gpt-5
|
|
||||||
patterns_repo: rodin/security-patterns
|
|
||||||
patterns_files: .
|
|
||||||
system_prompt_file: SECURITY_REVIEW.md
|
|
||||||
steps:
|
|
||||||
- uses: actions/checkout@v4
|
|
||||||
- uses: actions/setup-go@v5
|
|
||||||
with:
|
|
||||||
go-version: '1.26'
|
|
||||||
- run: go build -o review-bot ./cmd/review-bot
|
|
||||||
- name: Run ${{ matrix.name }} review
|
|
||||||
env:
|
|
||||||
VCS_URL: ${{ github.server_url }}
|
|
||||||
GITEA_REPO: ${{ github.repository }}
|
|
||||||
PR_NUMBER: ${{ github.event.pull_request.number }}
|
|
||||||
REVIEWER_TOKEN: ${{ secrets[matrix.token_secret] }}
|
|
||||||
REVIEWER_NAME: ${{ matrix.name }}
|
|
||||||
LLM_PROVIDER: aicore
|
|
||||||
LLM_MODEL: ${{ matrix.model }}
|
|
||||||
AICORE_CLIENT_ID: ${{ secrets.AICORE_CLIENT_ID }}
|
|
||||||
AICORE_CLIENT_SECRET: ${{ secrets.AICORE_CLIENT_SECRET }}
|
|
||||||
AICORE_AUTH_URL: ${{ secrets.AICORE_AUTH_URL }}
|
|
||||||
AICORE_API_URL: ${{ secrets.AICORE_API_URL }}
|
|
||||||
AICORE_RESOURCE_GROUP: ${{ secrets.AICORE_RESOURCE_GROUP }}
|
|
||||||
CONVENTIONS_FILE: CONVENTIONS.md
|
|
||||||
PATTERNS_REPO: ${{ matrix.patterns_repo || 'rodin/go-patterns' }}
|
|
||||||
PATTERNS_FILES: ${{ matrix.patterns_files || 'README.md,patterns/' }}
|
|
||||||
LLM_TIMEOUT: '600'
|
|
||||||
SYSTEM_PROMPT_FILE: ${{ matrix.system_prompt_file }}
|
|
||||||
run: ./review-bot
|
|
||||||
review-gate:
|
review-gate:
|
||||||
runs-on: ubuntu-24.04
|
runs-on: ubuntu-24.04
|
||||||
if: github.event_name == 'pull_request'
|
if: github.event_name == 'pull_request'
|
||||||
@@ -73,50 +28,83 @@ jobs:
|
|||||||
allow_review: ${{ steps.gate.outputs.allow_review }}
|
allow_review: ${{ steps.gate.outputs.allow_review }}
|
||||||
reason: ${{ steps.gate.outputs.reason }}
|
reason: ${{ steps.gate.outputs.reason }}
|
||||||
steps:
|
steps:
|
||||||
- name: Check self-review gate
|
- name: Check self-review gate
|
||||||
id: gate
|
id: gate
|
||||||
env:
|
env:
|
||||||
GITEA_TOKEN: ${{ secrets.RODIN_TOKEN }}
|
GITEA_TOKEN: ${{ secrets.RODIN_TOKEN }}
|
||||||
run: 'REPO=${{ github.repository }}
|
run: |
|
||||||
|
set -e
|
||||||
|
REPO=${{ github.repository }}
|
||||||
|
PR=${{ github.event.pull_request.number }}
|
||||||
|
SHA=${{ github.event.pull_request.head.sha }}
|
||||||
|
TTL_MIN=${SELF_REVIEW_TTL_MIN}
|
||||||
|
API="${{ github.server_url }}/api/v1"
|
||||||
|
|
||||||
PR=${{ github.event.pull_request.number }}
|
PR_JSON=$(curl -sS -H "Authorization: token $GITEA_TOKEN" "$API/repos/$REPO/pulls/$PR")
|
||||||
|
UPDATED_AT=$(echo "$PR_JSON" | jq -r .updated_at)
|
||||||
|
NOW=$(date -u +%s)
|
||||||
|
PR_TS=$(date -u -d "$UPDATED_AT" +%s)
|
||||||
|
AGE_MIN=$(( (NOW - PR_TS) / 60 ))
|
||||||
|
|
||||||
SHA=${{ github.event.pull_request.head.sha }}
|
COMMENTS=$(curl -sS -H "Authorization: token $GITEA_TOKEN" "$API/repos/$REPO/issues/$PR/comments?limit=200")
|
||||||
|
HAS_SR=$(echo "$COMMENTS" | jq -r --arg sha "$SHA" '[.[] | select(.user.login=="rodin") | select(.body|contains("Self-review against "+$sha)) | select(.body|test("(?im)^###\\s+Doc consistency\\b"))] | length')
|
||||||
|
|
||||||
TTL_MIN=${SELF_REVIEW_TTL_MIN}
|
if [ "$HAS_SR" -gt 0 ]; then
|
||||||
|
ALLOW=true
|
||||||
|
REASON=self-review
|
||||||
|
elif [ "$AGE_MIN" -ge "$TTL_MIN" ]; then
|
||||||
|
ALLOW=true
|
||||||
|
REASON=ttl
|
||||||
|
else
|
||||||
|
ALLOW=false
|
||||||
|
REASON=missing
|
||||||
|
fi
|
||||||
|
|
||||||
API="${{ github.server_url }}/api/v1"
|
echo "allow_review=$ALLOW" >> $GITHUB_OUTPUT
|
||||||
|
echo "reason=$REASON" >> $GITHUB_OUTPUT
|
||||||
|
|
||||||
PR_JSON=$(curl -sS -H "Authorization: token $GITEA_TOKEN" "$API/repos/$REPO/pulls/$PR")
|
review:
|
||||||
|
runs-on: ubuntu-24.04
|
||||||
UPDATED_AT=$(echo "$PR_JSON" | jq -r .updated_at)
|
if: github.event_name == 'pull_request' && needs.review-gate.outputs.allow_review == 'true'
|
||||||
|
needs: [test, review-gate]
|
||||||
NOW=$(date -u +%s)
|
strategy:
|
||||||
|
matrix:
|
||||||
PR_TS=$(date -u -d "$UPDATED_AT" +%s)
|
include:
|
||||||
|
- name: sonnet
|
||||||
AGE_MIN=$(( (NOW - PR_TS) / 60 ))
|
token_secret: SONNET_REVIEW_TOKEN
|
||||||
|
model: anthropic--claude-4.6-sonnet
|
||||||
COMMENTS=$(curl -sS -H "Authorization: token $GITEA_TOKEN" "$API/repos/$REPO/issues/$PR/comments?limit=200")
|
- name: gpt
|
||||||
|
token_secret: GPT_REVIEW_TOKEN
|
||||||
HAS_SR=$(echo "$COMMENTS" | jq -r --arg sha "$SHA" "[.[] | select(.user.login=="rodin")
|
model: gpt-5
|
||||||
| select(.body|contains("Self-review against "+\$sha)) | select(.body|test("(?im)^###
|
- name: security
|
||||||
\\s+Doc consistency\\b"))] | length")
|
token_secret: SECURITY_REVIEW_TOKEN
|
||||||
|
model: gpt-5
|
||||||
if [ "$HAS_SR" -gt 0 ]; then ALLOW=true; REASON=self-review; elif [ "$AGE_MIN"
|
patterns_repo: rodin/security-patterns
|
||||||
-ge "$TTL_MIN" ]; then ALLOW=true; REASON=ttl; else ALLOW=false; REASON=missing;
|
patterns_files: '.'
|
||||||
fi
|
system_prompt_file: SECURITY_REVIEW.md
|
||||||
|
steps:
|
||||||
echo "allow_review=$ALLOW" >> $GITHUB_OUTPUT
|
- uses: actions/checkout@v4
|
||||||
|
- uses: actions/setup-go@v5
|
||||||
echo "reason=$REASON" >> $GITHUB_OUTPUT'
|
with:
|
||||||
env:
|
go-version: '1.26'
|
||||||
SELF_REVIEW_TTL_MIN: '45'
|
- run: go build -o review-bot ./cmd/review-bot
|
||||||
'on':
|
- name: Run ${{ matrix.name }} review
|
||||||
pull_request:
|
env:
|
||||||
types:
|
VCS_URL: ${{ github.server_url }}
|
||||||
- opened
|
GITEA_REPO: ${{ github.repository }}
|
||||||
- synchronize
|
PR_NUMBER: ${{ github.event.pull_request.number }}
|
||||||
push:
|
REVIEWER_TOKEN: ${{ secrets[matrix.token_secret] }}
|
||||||
branches:
|
REVIEWER_NAME: ${{ matrix.name }}
|
||||||
- main
|
LLM_PROVIDER: aicore
|
||||||
|
LLM_MODEL: ${{ matrix.model }}
|
||||||
|
AICORE_CLIENT_ID: ${{ secrets.AICORE_CLIENT_ID }}
|
||||||
|
AICORE_CLIENT_SECRET: ${{ secrets.AICORE_CLIENT_SECRET }}
|
||||||
|
AICORE_AUTH_URL: ${{ secrets.AICORE_AUTH_URL }}
|
||||||
|
AICORE_API_URL: ${{ secrets.AICORE_API_URL }}
|
||||||
|
AICORE_RESOURCE_GROUP: ${{ secrets.AICORE_RESOURCE_GROUP }}
|
||||||
|
CONVENTIONS_FILE: 'CONVENTIONS.md'
|
||||||
|
PATTERNS_REPO: ${{ matrix.patterns_repo || 'rodin/go-patterns' }}
|
||||||
|
PATTERNS_FILES: ${{ matrix.patterns_files || 'README.md,patterns/' }}
|
||||||
|
LLM_TIMEOUT: '600'
|
||||||
|
SYSTEM_PROMPT_FILE: ${{ matrix.system_prompt_file }}
|
||||||
|
run: ./review-bot
|
||||||
|
|||||||
Reference in New Issue
Block a user