rodin/review-bot
2
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 6 Wiki Activity

test(#146): clarify t.TempDir() evaluation in subprocess env setup
PR Ready Gate / clear-labels (pull_request) Successful in 2s
Details
CI / test (pull_request) Successful in 16s
Details
CI / review (anthropic--claude-4.6-sonnet, sonnet, SONNET_REVIEW_TOKEN) (pull_request) Successful in 39s
Details
CI / review (gpt-5, security, ., rodin/security-patterns, SECURITY_REVIEW.md, SECURITY_REVIEW_TOKEN) (pull_request) Successful in 46s
Details
CI / review (gpt-5, gpt, GPT_REVIEW_TOKEN) (pull_request) Successful in 59s
Details

Browse Source
This commit is contained in:
Rodin
2026-05-15 11:59:25 +00:00
parent 9b64c605f8
commit 290ce99226
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cmd/review-bot/main_test.go
+4
View File
@@ -1527,6 +1527,8 @@ func TestMainSubprocess_InvalidDocMapPath(t *testing.T) {
} }
cmd := exec.Command(os.Args[0], "-test.run=TestMainSubprocess_InvalidDocMapPath") cmd := exec.Command(os.Args[0], "-test.run=TestMainSubprocess_InvalidDocMapPath")
// t.TempDir() is evaluated here in the outer process, producing a real directory
// that is passed as the GITHUB_WORKSPACE env var string to the subprocess.
cmd.Env = append(cleanEnv(), cmd.Env = append(cleanEnv(),
"TEST_SUBPROCESS_MAIN=1", "TEST_SUBPROCESS_MAIN=1",
"GITHUB_WORKSPACE="+t.TempDir(), "GITHUB_WORKSPACE="+t.TempDir(),
@@ -1564,6 +1566,8 @@ func TestMainSubprocess_InvalidDocMapFile(t *testing.T) {
} }
cmd := exec.Command(os.Args[0], "-test.run=TestMainSubprocess_InvalidDocMapFile") cmd := exec.Command(os.Args[0], "-test.run=TestMainSubprocess_InvalidDocMapFile")
// t.TempDir() is evaluated here in the outer process, producing a real directory
// that is passed as the GITHUB_WORKSPACE env var string to the subprocess.
cmd.Env = append(cleanEnv(), cmd.Env = append(cleanEnv(),
"TEST_SUBPROCESS_MAIN=1", "TEST_SUBPROCESS_MAIN=1",
"GITHUB_WORKSPACE="+t.TempDir(), "GITHUB_WORKSPACE="+t.TempDir(),