fix(nit): align CommitID field in vcs/types.go and document no-op in github/review.go
PR Ready Gate / clear-labels (pull_request) Successful in 2s
CI / test (pull_request) Successful in 19s
CI / review (anthropic--claude-4.6-sonnet, sonnet, SONNET_REVIEW_TOKEN) (pull_request) Successful in 29s
CI / review (gpt-5, security, ., rodin/security-patterns, SECURITY_REVIEW.md, SECURITY_REVIEW_TOKEN) (pull_request) Successful in 48s
CI / review (gpt-5, gpt, GPT_REVIEW_TOKEN) (pull_request) Successful in 1m38s
PR Ready Gate / clear-labels (pull_request) Successful in 2s
CI / test (pull_request) Successful in 19s
CI / review (anthropic--claude-4.6-sonnet, sonnet, SONNET_REVIEW_TOKEN) (pull_request) Successful in 29s
CI / review (gpt-5, security, ., rodin/security-patterns, SECURITY_REVIEW.md, SECURITY_REVIEW_TOKEN) (pull_request) Successful in 48s
CI / review (gpt-5, gpt, GPT_REVIEW_TOKEN) (pull_request) Successful in 1m38s
This commit is contained in:
@@ -108,6 +108,7 @@ func (c *Client) PostReview(ctx context.Context, owner, repo string, number int,
|
|||||||
} else if payload.CommitID != comment.CommitID {
|
} else if payload.CommitID != comment.CommitID {
|
||||||
return nil, ErrConflictingCommitIDs
|
return nil, ErrConflictingCommitIDs
|
||||||
}
|
}
|
||||||
|
// else: matching SHA is a no-op by design
|
||||||
}
|
}
|
||||||
payload.Comments = append(payload.Comments, reviewCommentEntry{
|
payload.Comments = append(payload.Comments, reviewCommentEntry{
|
||||||
Path: comment.Path,
|
Path: comment.Path,
|
||||||
|
|||||||
@@ -98,5 +98,6 @@ type ReviewRequest struct {
|
|||||||
// If empty, the platform defaults to the current PR head.
|
// If empty, the platform defaults to the current PR head.
|
||||||
// Adapters use this as the primary commit anchor for the review submission.
|
// Adapters use this as the primary commit anchor for the review submission.
|
||||||
CommitID string `json:"commit_id,omitempty"`
|
CommitID string `json:"commit_id,omitempty"`
|
||||||
|
|
||||||
Comments []ReviewComment `json:"comments,omitempty"`
|
Comments []ReviewComment `json:"comments,omitempty"`
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user