From 151199e43633d03216aa1fea85992f538bee3c0e Mon Sep 17 00:00:00 2001 From: Rodin Date: Fri, 15 May 2026 07:47:02 +0000 Subject: [PATCH] fix(docs): correct rule numbering and missing sr-fix template reference - Rule 11 (new issue pickup) was incorrectly labeled Rule 10 in SKILL.md dispatch rules table - docs/dev-loop-spec.md referenced non-existent scripts/check-deps.sh instead of correct scripts/test/check-invariants.sh - Add sr-fix.md to worker templates tables in both SKILL.md and spec --- SKILL.md | 3 ++- docs/dev-loop-spec.md | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/SKILL.md b/SKILL.md index c26499f..e439774 100644 --- a/SKILL.md +++ b/SKILL.md @@ -53,7 +53,7 @@ The model **never** assesses project state or makes dispatch decisions. | 8 | Unacknowledged bot review findings | SPAWN:address-feedback | | 9 | Unresolved inline diff comments | SPAWN:address-feedback | | 10 | All checks pass | HANDOFF | -| 10 | No open PRs + no ACTIVE_WIP | SPAWN:impl (next issue) | +| 11 | No open PRs + no ACTIVE_WIP | SPAWN:impl (next issue) | ## Files @@ -61,6 +61,7 @@ The model **never** assesses project state or makes dispatch decisions. |------|-------------| | `~/.openclaw/workspace/scripts/dev-loop-dispatch.sh` | Dispatch script — pure bash | | `~/.openclaw/workspace/scripts/worker-tasks/self-review.md` | Self-review worker template | +| `~/.openclaw/workspace/scripts/worker-tasks/sr-fix.md` | Fix findings from self-review | | `~/.openclaw/workspace/scripts/worker-tasks/ci-fix.md` | CI fix worker template | | `~/.openclaw/workspace/scripts/worker-tasks/address-feedback.md` | Address feedback worker template | | `~/.openclaw/workspace/scripts/worker-tasks/findings.md` | Address REQUEST_CHANGES findings | diff --git a/docs/dev-loop-spec.md b/docs/dev-loop-spec.md index eec9a12..9e56435 100644 --- a/docs/dev-loop-spec.md +++ b/docs/dev-loop-spec.md @@ -254,6 +254,7 @@ Each worker receives a precise task description with substituted values: | Template | Trigger | Key job | |----------|---------|---------| | `self-review.md` | No clean self-review | Post self-review comment, remove WIP | +| `sr-fix.md` | Self-review needs attention | Address self-review findings, push, remove WIP | | `ci-fix.md` | CI failing | Diagnose, fix, push, remove WIP | | `address-feedback.md` | Unacknowledged findings or inline comments | Address feedback, push, remove WIP | | `findings.md` | REQUEST_CHANGES present | Address REQUEST_CHANGES, push, remove WIP | @@ -267,7 +268,7 @@ Workers **always** remove the WIP label on completion and reply `NO_REPLY`. ## 9. Fixes for Issues #144 and #145 **Issue #144** (autonomous merge): -The dispatch script contains no merge API calls anywhere. The `scripts/check-deps.sh` +The dispatch script contains no merge API calls anywhere. The `scripts/test/check-invariants.sh` invariant `S1` verifies this. Workers do not receive merge instructions. **Issue #145** (merged despite REQUEST_CHANGES):