rodin/review-bot
2
1
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases 6 Wiki Activity

test(github): use t.Run subtests in TestTranslateGitHubReviewState; doc: note nil body in DeleteReview
PR Ready Gate / clear-labels (pull_request) Successful in 1s
Details
CI / test (pull_request) Successful in 20s
Details
CI / review (anthropic--claude-4.6-sonnet, sonnet, SONNET_REVIEW_TOKEN) (pull_request) Successful in 38s
Details
CI / review (gpt-5, security, ., rodin/security-patterns, SECURITY_REVIEW.md, SECURITY_REVIEW_TOKEN) (pull_request) Successful in 1m4s
Details
CI / review (gpt-5, gpt, GPT_REVIEW_TOKEN) (pull_request) Successful in 2m8s
Details

Browse Source
This commit is contained in:
claw
2026-05-13 02:04:06 -07:00
parent 332a0e1cb7
commit 036b246cb9
2 changed files with 14 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
github/review.go
+1
View File
@@ -173,6 +173,7 @@ func (c *Client) DeleteReview(ctx context.Context, owner, repo string, number in
reqURL := fmt.Sprintf("%s/repos/%s/%s/pulls/%d/reviews/%d", reqURL := fmt.Sprintf("%s/repos/%s/%s/pulls/%d/reviews/%d",
c.baseURL, url.PathEscape(owner), url.PathEscape(repo), number, reviewID) c.baseURL, url.PathEscape(owner), url.PathEscape(repo), number, reviewID)
// nil body: the GitHub DELETE endpoint for reviews requires no request body.
_, err := c.doRequestWithBody(ctx, http.MethodDelete, reqURL, nil) _, err := c.doRequestWithBody(ctx, http.MethodDelete, reqURL, nil)
if err != nil { if err != nil {
var apiErr *APIError var apiErr *APIError
github/review_test.go
+9 -6
View File
@@ -348,21 +348,24 @@ func TestDismissReview_401(t *testing.T) {
func TestTranslateGitHubReviewState(t *testing.T) { func TestTranslateGitHubReviewState(t *testing.T) {
tests := []struct { tests := []struct {
name string
input string input string
want string want string
}{ }{
{"APPROVED", "APPROVED"}, {"approved passes through", "APPROVED", "APPROVED"},
{"CHANGES_REQUESTED", "REQUEST_CHANGES"}, {"changes_requested maps to REQUEST_CHANGES", "CHANGES_REQUESTED", "REQUEST_CHANGES"},
{"COMMENTED", "COMMENT"}, {"commented maps to COMMENT", "COMMENTED", "COMMENT"},
{"DISMISSED", "DISMISSED"}, {"dismissed passes through", "DISMISSED", "DISMISSED"},
{"UNKNOWN_STATE", "UNKNOWN_STATE"}, {"unknown state passes through", "UNKNOWN_STATE", "UNKNOWN_STATE"},
{"", ""}, {"empty string passes through", "", ""},
} }
for _, tt := range tests { for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
got := translateGitHubReviewState(tt.input) got := translateGitHubReviewState(tt.input)
if got != tt.want { if got != tt.want {
t.Errorf("translateGitHubReviewState(%q) = %q, want %q", tt.input, got, tt.want) t.Errorf("translateGitHubReviewState(%q) = %q, want %q", tt.input, got, tt.want)
} }
})
} }
} }