Aaron Weiker aweiker
  • Joined on 2026-04-12
aweiker approved rodin/review-bot#54 2026-05-10 08:10:25 +00:00
feat: native SAP AI Core support
aweiker suggested changes for rodin/review-bot#53 2026-05-10 06:57:15 +00:00
fix: skip posting review when HEAD moves during evaluation

These CI changes are wrong; can't remove these just because there's an error.

aweiker commented on pull request rodin/review-bot#53 2026-05-10 06:57:15 +00:00
fix: skip posting review when HEAD moves during evaluation

Don't remove these models as a part of tihs work. Fix the issue first.

aweiker suggested changes for rodin/review-bot#50 2026-05-10 06:55:30 +00:00
feat: add native SAP AI Core support

Looking at the feedback there are some code quality issues that should be addressed.

aweiker pushed to main at rodin/review-bot 2026-05-08 02:32:38 +00:00
2089ca0f2d Merge pull request 'fix: retry on transient LLM response body truncation' (#48) from fix/response-body-truncation into main
db479d0ff4 fix: retry on transient LLM response body truncation
Compare 2 commits »
aweiker closed issue rodin/review-bot#47 2026-05-08 02:32:37 +00:00
LLM response body truncated: intermittent JSON parse failure
aweiker merged pull request rodin/review-bot#48 2026-05-08 02:32:37 +00:00
fix: retry on transient LLM response body truncation
aweiker suggested changes for rodin/review-bot#48 2026-05-08 01:41:50 +00:00
fix: retry on transient LLM response body truncation

Make it retry up to 5 times. Each time wait 5 seconds between retries.

aweiker pushed to docs/impl-doc-override-rule at rodin/elixir-patterns 2026-05-02 17:14:02 +00:00
d3adeaac25 fix: standardize cross-reference link text for Pattern 10 subsection
aweiker commented on pull request rodin/elixir-patterns#2 2026-05-02 17:09:39 +00:00
docs: add rule for when @impl functions earn their own @doc

[MINOR] Inconsistent cross-reference link text.

aweiker commented on pull request rodin/elixir-patterns#2 2026-05-02 17:09:39 +00:00
docs: add rule for when @impl functions earn their own @doc

PR Review Summary

aweiker commented on pull request rodin/elixir-patterns#2 2026-05-02 17:09:35 +00:00
docs: add rule for when @impl functions earn their own @doc

[MINOR] Inconsistent cross-reference link text.

aweiker commented on pull request rodin/elixir-patterns#2 2026-05-02 17:09:35 +00:00
docs: add rule for when @impl functions earn their own @doc

PR Review Summary

aweiker created pull request rodin/elixir-patterns#2 2026-05-02 17:04:17 +00:00
docs: add rule for when @impl functions earn their own @doc
aweiker pushed to docs/impl-doc-override-rule at rodin/elixir-patterns 2026-05-02 17:04:02 +00:00
edef02ed0f docs: add rule for when @impl functions earn their own @doc
aweiker created branch docs/impl-doc-override-rule in rodin/elixir-patterns 2026-05-02 17:04:02 +00:00
aweiker suggested changes for rodin/review-bot#31 2026-05-02 14:16:31 +00:00
fix: remove worst-wins escalation logic

No new tests were added for detecting the same token was used.

aweiker commented on pull request rodin/review-bot#31 2026-05-02 14:15:04 +00:00
fix: remove worst-wins escalation logic

this should also make it fall into a mode where it only writes new reviews; never updates any review as we don't want to do that logic. What about review state? That might get clobbered too.

aweiker suggested changes for rodin/review-bot#31 2026-05-02 14:09:30 +00:00
fix: remove worst-wins escalation logic

what happens when someone doesn't follow instructions and uses the same token twice? can we detect and fallback into a safe mode?